Description
Rafal Kopaczka
2014-09-19 15:19:18 UTC
*** Bug 13034 has been marked as a duplicate of this bug. *** Created attachment 33621 [details] [review] Bug 12971 - Regression: Patron print summary doesn't show checkouts A patron's print summary should contain a list of checked out items as it did in 3.16.2 and earlier. Please note, as of 3.16.2 reserves were no longer part of the print summary and thus are not part of this bug fixing patch. Test Plan: 1) Find a patron with checked out items 2) Choose Print -> Print summary 3) Note the lack of a list of checkouts 4) Apply this patch 5) Reload the page 5) Print the summary again 6) Note the list of checkouts This submitted patch migrates the print function to a separate script and pares down the the data to only what is required for the template. This will keep moremember.pl from getting any more complex, and provides us with a focused patron printing feature. This will also be better in the long run for converting this template into a configurable slip. Note, the template itself has much whitespace alteration to improve the readability of the template, but otherwise has remained largely unchanged. The only changes made were to take advantage of Koha's TT plugins to remove the need to pass some values from the script to the template. Created attachment 33623 [details] [review] Bug 12971 - Regression: Patron print summary doesn't show checkouts A patron's print summary should contain a list of checked out items as it did in 3.16.2 and earlier. Please note, as of 3.16.2 reserves were no longer part of the print summary and thus are not part of this bug fixing patch. Test Plan: 1) Find a patron with checked out items 2) Choose Print -> Print summary 3) Note the lack of a list of checkouts 4) Apply this patch 5) Reload the page 5) Print the summary again 6) Note the list of checkouts Created attachment 33625 [details] [review] [SIGNED-OFF] Bug 12971 - Regression: Patron print summary doesn't show checkouts A patron's print summary should contain a list of checked out items as it did in 3.16.2 and earlier. Please note, as of 3.16.2 reserves were no longer part of the print summary and thus are not part of this bug fixing patch. Test Plan: 1) Find a patron with checked out items 2) Choose Print -> Print summary 3) Note the lack of a list of checkouts 4) Apply this patch 5) Reload the page 5) Print the summary again 6) Note the list of checkouts Signed-off-by: Owen Leonard <oleonard@myacpl.org> I see one thing which has been missed, but it could be taken care of in a follow-up: Previously the table of checkouts indicated in the "Status" column whether the item is overdue. Now the status column is empty for all checkouts. I notice a couple of other issues that would be nice to fix but which existed in 3.14.x: - The date formatting is wrong "2013-08-21T23:59:00" - The checkouts don't appear to have any relevant order. I would expect them to be ordered by due date -- perhaps according to the previousIssuesDefaultSortOrder system pref? Created attachment 33628 [details] [review] [PASSED QA] Bug 12971 - Regression: Patron print summary doesn't show checkouts A patron's print summary should contain a list of checked out items as it did in 3.16.2 and earlier. Please note, as of 3.16.2 reserves were no longer part of the print summary and thus are not part of this bug fixing patch. Test Plan: 1) Find a patron with checked out items 2) Choose Print -> Print summary 3) Note the lack of a list of checkouts 4) Apply this patch 5) Reload the page 5) Print the summary again 6) Note the list of checkouts Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Works as described, apart from the missing status information that Owen already noted on the bug. Passes tests and QA script. Kyle, please fix the problem Owen noted about the status not displaying in a follow-up, thx! Created attachment 33650 [details] [review] Bug 12971 [QA Followup] * Makes the status column display "Overdue!" if overdue * Fixes the due date formatting * Sorts the checkouts by date due ( oldest to newest ) Note: I found no evidence that this data was previously sorted, so I kept it simple. Sorting based on system preferences could be a future enhancement. The follow-up triggers an error if you try to print a summary for someone who has no checkouts. Created attachment 33664 [details] [review] Bug 12971 [QA Followup] - Fix error caused by patron not having any checkouts Created attachment 33665 [details] [review] Bug 12971 [QA Followup] * Makes the status column display "Overdue!" if overdue * Fixes the due date formatting * Sorts the checkouts by date due ( oldest to newest ) Note: I found no evidence that this data was previously sorted, so I kept it simple. Sorting based on system preferences could be a future enhancement. Signed-off-by: Owen Leonard <oleonard@myacpl.org> This fixes the issues described for patrons with existing checkouts. Created attachment 33666 [details] [review] Bug 12971 [QA Followup] - Fix error caused by patron not having any checkouts Signed-off-by: Owen Leonard <oleonard@myacpl.org> This successfully fixes the problem observed when a patron has no checkouts. Patches pushed to master. Thanks! Will we be pulling this fix back to 3.16? Cheers, Liz (In reply to Liz Rea from comment #15) > Will we be pulling this fix back to 3.16? > > Cheers, > Liz Pushed to 3.16.x, will be in 3.16.7 (In reply to Liz Rea from comment #15) > Will we be pulling this fix back to 3.16? > > Cheers, > Liz Hmm, I cant reproduce this bug in 3.16.6+ ie: the checkouts are showing OK from print-summary you are hitting this bug in 3.16.x Liz? Created attachment 35484 [details]
checkouts show in summary, 3.16.6
Comment on attachment 35484 [details]
checkouts show in summary, 3.16.6
Yes, we saw it, but it's been ages ago. Possibly it was fixed somewhere else.
|