Summary: | Transfer slip and transfer message (blue box) can conflict | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Circulation | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, julian.maurice, jzairo, kyle.m.hall, kyle, mtj, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 12972 - Transfer slip and transfer message (blue box) can conflict
[SIGNED-OFF] Bug 12972 - Transfer slip and transfer message (blue box) can conflict Bug 12972 - Transfer slip and transfer message (blue box) can conflict |
Description
Nick Clemens (kidclamp)
2014-09-19 21:23:26 UTC
Created attachment 60810 [details] [review] Bug 12972 - Transfer slip and transfer message (blue box) can conflict Instead of passing the homebranch to the slip, let's pass TransferWaitingAt (the value we display) To test: 1 - Check in an item that will initiate a transfer (hold or automatic item return) 2 - Note the transfer message and receipt match 3 - Remove the reason for transfer (bot don't cancel transfer) i.e. cancel hold or change homebranch of item to current library 4 - Check the item in again 5 - Note the message displays the transfer destination and the slip shows the homebranch 6 - Apply patch 7 - Repeat 5 but note slip and message match 8 - Test any edge cases for correctness 9 - sign off Created attachment 60864 [details] [review] [SIGNED-OFF] Bug 12972 - Transfer slip and transfer message (blue box) can conflict Instead of passing the homebranch to the slip, let's pass TransferWaitingAt (the value we display) To test: 1 - Check in an item that will initiate a transfer (hold or automatic item return) 2 - Note the transfer message and receipt match 3 - Remove the reason for transfer (bot don't cancel transfer) i.e. cancel hold or change homebranch of item to current library 4 - Check the item in again 5 - Note the message displays the transfer destination and the slip shows the homebranch 6 - Apply patch 7 - Repeat 5 but note slip and message match 8 - Test any edge cases for correctness 9 - sign off Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 60887 [details] [review] Bug 12972 - Transfer slip and transfer message (blue box) can conflict Instead of passing the homebranch to the slip, let's pass TransferWaitingAt (the value we display) To test: 1 - Check in an item that will initiate a transfer (hold or automatic item return) 2 - Note the transfer message and receipt match 3 - Remove the reason for transfer (bot don't cancel transfer) i.e. cancel hold or change homebranch of item to current library 4 - Check the item in again 5 - Note the message displays the transfer destination and the slip shows the homebranch 6 - Apply patch 7 - Repeat 5 but note slip and message match 8 - Test any edge cases for correctness 9 - sign off Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Nick! This patch has been pushed to 16.11.x and will be in 16.11.07. Pushed to 3.22.x for 3.22.20 Pushed to 16.05.x, for 16.05.12 release |