When an item is being transferred to another branch (for a hold or because it was returned to another branch) with AutomaticItemReturn='Do' if the reason for the transfer is removed (hold cancelled or item permanent location edited) the transfer message still states the book should be sent to the other branch, but the printed slip lists the home library To recreate (make sure AutomaticItemReutrn='Do'): 1 - Place a hold for delivery to LibraryB on an item at LibraryA 2 - Check in the item at LibraryA and confirm transfer and print slip - message and slip should agree 3 - Cancel the hold and check the item in at LibraryA and print slip - message still states "transfer to LibraryB", slip states "transfer to LibraryA" alternately: 1 - check in an item from LibraryB at LibraryA, print transfer slip - message and slip should say destination LibraryB 2 - change the permanent location of the item to LibraryA 3 - check in the item at LibraryA, message says LibraryB, slip says LibraryA
Created attachment 60810 [details] [review] Bug 12972 - Transfer slip and transfer message (blue box) can conflict Instead of passing the homebranch to the slip, let's pass TransferWaitingAt (the value we display) To test: 1 - Check in an item that will initiate a transfer (hold or automatic item return) 2 - Note the transfer message and receipt match 3 - Remove the reason for transfer (bot don't cancel transfer) i.e. cancel hold or change homebranch of item to current library 4 - Check the item in again 5 - Note the message displays the transfer destination and the slip shows the homebranch 6 - Apply patch 7 - Repeat 5 but note slip and message match 8 - Test any edge cases for correctness 9 - sign off
Created attachment 60864 [details] [review] [SIGNED-OFF] Bug 12972 - Transfer slip and transfer message (blue box) can conflict Instead of passing the homebranch to the slip, let's pass TransferWaitingAt (the value we display) To test: 1 - Check in an item that will initiate a transfer (hold or automatic item return) 2 - Note the transfer message and receipt match 3 - Remove the reason for transfer (bot don't cancel transfer) i.e. cancel hold or change homebranch of item to current library 4 - Check the item in again 5 - Note the message displays the transfer destination and the slip shows the homebranch 6 - Apply patch 7 - Repeat 5 but note slip and message match 8 - Test any edge cases for correctness 9 - sign off Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 60887 [details] [review] Bug 12972 - Transfer slip and transfer message (blue box) can conflict Instead of passing the homebranch to the slip, let's pass TransferWaitingAt (the value we display) To test: 1 - Check in an item that will initiate a transfer (hold or automatic item return) 2 - Note the transfer message and receipt match 3 - Remove the reason for transfer (bot don't cancel transfer) i.e. cancel hold or change homebranch of item to current library 4 - Check the item in again 5 - Note the message displays the transfer destination and the slip shows the homebranch 6 - Apply patch 7 - Repeat 5 but note slip and message match 8 - Test any edge cases for correctness 9 - sign off Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Nick!
This patch has been pushed to 16.11.x and will be in 16.11.07.
Pushed to 3.22.x for 3.22.20
Pushed to 16.05.x, for 16.05.12 release