Summary: | Static fine should apply only once for a given borrower | ||
---|---|---|---|
Product: | Koha | Reporter: | Sophie MEYNIEUX <sophie.meynieux> |
Component: | Circulation | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6858 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 13018 : Static fine should be charged only once
Bug 13018 : Static fine should be charged only once [PASSED QA] Bug 13018 : Static fine should be charged only once |
Description
Sophie MEYNIEUX
2014-10-01 09:53:47 UTC
Created attachment 31967 [details] [review] Bug 13018 : Static fine should be charged only once Test plan (see Bug 6858 for using staticfine.pl) : For a user (of a given category and library) with several overdues, launch the script : staticfines.pl --category CAT,AMOUNT --library LIB --delay DELAY Then, check that the user has been charged of AMOUNT if the due date of the most late item plus the delay is *before* today. One day later, re-execute the script with the same parameters and check that the fine has not been charged twice. Without patch, the fine is charged twice, with patch the user already charged is skipped (see output in debug mode) Created attachment 32295 [details] [review] Bug 13018 : Static fine should be charged only once Test plan (see Bug 6858 for using staticfine.pl) : For a user (of a given category and library) with several overdues, launch the script : staticfines.pl --category CAT,AMOUNT --library LIB --delay DELAY Then, check that the user has been charged of AMOUNT if the due date of the most late item plus the delay is *before* today. One day later, re-execute the script with the same parameters and check that the fine has not been charged twice. Without patch, the fine is charged twice, with patch the user already charged is skipped (see output in debug mode) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 32425 [details] [review] [PASSED QA] Bug 13018 : Static fine should be charged only once Test plan (see Bug 6858 for using staticfine.pl) : For a user (of a given category and library) with several overdues, launch the script : staticfines.pl --category CAT,AMOUNT --library LIB --delay DELAY Then, check that the user has been charged of AMOUNT if the due date of the most late item plus the delay is *before* today. One day later, re-execute the script with the same parameters and check that the fine has not been charged twice. Without patch, the fine is charged twice, with patch the user already charged is skipped (see output in debug mode) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Without the patch, the fine will be applied every time the script is run. With the patch the fine will only be applied once. Passes tests and QA script. Patch pushed to master. Thanks Sophie! |