Summary: | Members are restricted even if the debarment is ended - opac-reserve | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Patrons | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13107 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12292 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 12134 | ||
Bug Blocks: | |||
Attachments: |
Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve
Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve [PASSED QA] Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve |
Description
Fridolin Somers
2014-10-17 16:36:02 UTC
Created attachment 32518 [details] [review] Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve This is the same issue as bug 12134. Test Plan: 1) Add a manual restriction to a patron with expiration date in the past 2) Go on the OPAC and connect 3) Try to add an hold on a record (opac-reserve.pl) 3) Note the warning message "Sorry, you cannot place holds because your account has been frozen ..." 4) Apply this patch 5) Repeat step 2 6) Note the warning message does not appear anymore Created attachment 32523 [details] [review] Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve This is the same issue as bug 12134. Test Plan: 1) Add a manual restriction to a patron with expiration date in the past 2) Go on the OPAC and connect 3) Try to add an hold on a record (opac-reserve.pl) 3) Note the warning message "Sorry, you cannot place holds because your account has been frozen ..." 4) Apply this patch 5) Repeat step 2 6) Note the warning message does not appear anymore Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 32571 [details] [review] [PASSED QA] Bug 13108 - Members are restricted even if the debarment is ended - opac-reserve This is the same issue as bug 12134. Test Plan: 1) Add a manual restriction to a patron with expiration date in the past 2) Go on the OPAC and connect 3) Try to add an hold on a record (opac-reserve.pl) 3) Note the warning message "Sorry, you cannot place holds because your account has been frozen ..." 4) Apply this patch 5) Repeat step 2 6) Note the warning message does not appear anymore Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Makes code cleaner, also works as described. NOTE: If you set a debarment with date in the past in the GUI, there will be no entry in borrowers.debarred and you won't be able to see the problem. Set one with a date in the future and then alter the date in borrower_debarments and borrowers.debarred. Patch pushed to master. Thanks Fridolin! |