| Summary: | Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, liz, nick, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 10860 | ||
| Bug Blocks: | 13179 | ||
| Attachments: |
Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on
Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on [PASSED QA] Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on |
||
|
Description
Owen Leonard
2014-10-31 16:30:02 UTC
*** Bug 13185 has been marked as a duplicate of this bug. *** Created attachment 33168 [details] [review] Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on This patch addresses the case where OnSiteCheckoutsForce is enabled and the user is checking out to a patron who is blocked from checking out. Instead of showing the 'specify due date' form (which is disabled) this patch hides it and highlights the on-site checkout controls. This patch adds some CSS and consolidates some redundant CSS. To test, load a patron for checkout under the following conditions: 1. OnSiteCheckoutsForce is off and patron is not blocked from checkout 2. OnSiteCheckoutsForce is off, patron is blocked from checkout (for being expired or restricted). 3. OnSiteCheckoutsForce is on and patron is not blocked from checkout 4. OnSiteCheckoutsForce is on and patron is blocked from checkout Created attachment 33283 [details] [review] Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on This patch addresses the case where OnSiteCheckoutsForce is enabled and the user is checking out to a patron who is blocked from checking out. Instead of showing the 'specify due date' form (which is disabled) this patch hides it and highlights the on-site checkout controls. This patch adds some CSS and consolidates some redundant CSS. To test, load a patron for checkout under the following conditions: 1. OnSiteCheckoutsForce is off and patron is not blocked from checkout 2. OnSiteCheckoutsForce is off, patron is blocked from checkout (for being expired or restricted). 3. OnSiteCheckoutsForce is on and patron is not blocked from checkout 4. OnSiteCheckoutsForce is on and patron is blocked from checkout Signed-off-by: Liz Rea <liz@catalyst.net.nz> Checked these 4 conditions, plus that if a specified due date was allowed, that it was enforced. I noted that the on-site checkouts seemed to take longer to process, but this probably isn't the place for that sort of complaint. Created attachment 33285 [details] [review] [PASSED QA] Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on This patch addresses the case where OnSiteCheckoutsForce is enabled and the user is checking out to a patron who is blocked from checking out. Instead of showing the 'specify due date' form (which is disabled) this patch hides it and highlights the on-site checkout controls. This patch adds some CSS and consolidates some redundant CSS. To test, load a patron for checkout under the following conditions: 1. OnSiteCheckoutsForce is off and patron is not blocked from checkout 2. OnSiteCheckoutsForce is off, patron is blocked from checkout (for being expired or restricted). 3. OnSiteCheckoutsForce is on and patron is not blocked from checkout 4. OnSiteCheckoutsForce is on and patron is blocked from checkout Signed-off-by: Liz Rea <liz@catalyst.net.nz> Checked these 4 conditions, plus that if a specified due date was allowed, that it was enforced. I noted that the on-site checkouts seemed to take longer to process, but this probably isn't the place for that sort of complaint. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Small visual improvment for a new feature. No problems found. Patch pushed to master. Thanks Owen! |