Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on
Summary: Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsFor...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 10860
Blocks: 13179
  Show dependency treegraph
 
Reported: 2014-10-31 16:30 UTC by Owen Leonard
Modified: 2015-06-04 23:33 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on (6.44 KB, patch)
2014-11-03 17:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on (6.66 KB, patch)
2014-11-06 03:19 UTC, Liz Rea
Details | Diff | Splinter Review
[PASSED QA] Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on (6.79 KB, patch)
2014-11-06 06:04 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-10-31 16:30:02 UTC
If OnSiteCheckoutsForce is enabled and you are checking out to a patron who is otherwise blocked from checking out, any checkouts will be automatically considered on-site checkouts and due at the end of the day.

In this case the "specify due date" control is redundant. I propose to alter the form so that there is clearer indication that an on-site checkout is being enforced.
Comment 1 Owen Leonard 2014-10-31 20:56:28 UTC
*** Bug 13185 has been marked as a duplicate of this bug. ***
Comment 2 Owen Leonard 2014-11-03 17:19:12 UTC Comment hidden (obsolete)
Comment 3 Liz Rea 2014-11-06 03:19:16 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-11-06 06:04:28 UTC
Created attachment 33285 [details] [review]
[PASSED QA] Bug 13183 - Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on

This patch addresses the case where OnSiteCheckoutsForce is enabled and
the user is checking out to a patron who is blocked from checking out.
Instead of showing the 'specify due date' form (which is disabled) this
patch hides it and highlights the on-site checkout controls.

This patch adds some CSS and consolidates some redundant CSS.

To test, load a patron for checkout under the following conditions:

1. OnSiteCheckoutsForce is off and patron is not blocked from checkout
2. OnSiteCheckoutsForce is off, patron is blocked from checkout (for
   being expired or restricted).
3. OnSiteCheckoutsForce is on and patron is not blocked from checkout
4. OnSiteCheckoutsForce is on and patron is blocked from checkout

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Checked these 4 conditions, plus that if a specified due date was allowed, that it was enforced.

I noted that the on-site checkouts seemed to take longer to process, but this probably isn't the place for that sort of complaint.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Small visual improvment for a new feature. No problems found.
Comment 5 Tomás Cohen Arazi 2014-11-06 16:54:46 UTC
Patch pushed to master.

Thanks Owen!