Summary: | "Always show checkouts immediately" cookie should persist across sessions | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, f.demians, gmcharlt, gwilliams, jsasse, kyle.m.hall, magnus, mtj, p.thrasher, sfayle, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 11703, 12550 | ||
Bug Blocks: | |||
Attachments: |
Bug 13196 - "Always show checkouts immediately" cookie should persist across sessions
Bug 13196 - "Always show checkouts immediately" cookie should persist across sessions [PASSED QA] Bug 13196 - "Always show checkouts immediately" cookie should persist across sessions |
Description
Owen Leonard
2014-11-04 17:00:44 UTC
Created attachment 33206 [details] [review] Bug 13196 - "Always show checkouts immediately" cookie should persist across sessions This patch modifies the way the checkouts script sets the "Always show checkouts" cookie so that it is set with an explicit expiration date (+365 days). This will allow the cookie to persist across browser sesssions. To test, apply the patch and clear your browser cookies to start with a clean slate. - Check out to a patron who has existing checkouts. Their checkouts should not load by default. - Check the "Always show checkouts immediately" checkbox. - Close your browser. - Reopen your browser and check out to that patron again. Checkouts should now be displayed by default. Created attachment 33219 [details] [review] Bug 13196 - "Always show checkouts immediately" cookie should persist across sessions This patch modifies the way the checkouts script sets the "Always show checkouts" cookie so that it is set with an explicit expiration date (+365 days). This will allow the cookie to persist across browser sesssions. To test, apply the patch and clear your browser cookies to start with a clean slate. - Check out to a patron who has existing checkouts. Their checkouts should not load by default. - Check the "Always show checkouts immediately" checkbox. - Close your browser. - Reopen your browser and check out to that patron again. Checkouts should now be displayed by default. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as described. I confirm that without this patch, the un-persistance of "show checkouts" choice is very perturbing for librarians coming from previous version of Koha. Created attachment 33269 [details] [review] [PASSED QA] Bug 13196 - "Always show checkouts immediately" cookie should persist across sessions This patch modifies the way the checkouts script sets the "Always show checkouts" cookie so that it is set with an explicit expiration date (+365 days). This will allow the cookie to persist across browser sesssions. To test, apply the patch and clear your browser cookies to start with a clean slate. - Check out to a patron who has existing checkouts. Their checkouts should not load by default. - Check the "Always show checkouts immediately" checkbox. - Close your browser. - Reopen your browser and check out to that patron again. Checkouts should now be displayed by default. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Works as described. I confirm that without this patch, the un-persistance of "show checkouts" choice is very perturbing for librarians coming from previous version of Koha. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, no problems found. Patch pushed to master. Thanks Owen! This needs to be backported to 3.16.x (In reply to Mason James from comment #5) > This needs to be backported to 3.16.x This patch depends on Bug 12550, so I assume it is not relevant to 3.16.x. Chris, can you consider this for the next 3.18.x? We have had several libraries asking for it since their update to 3.18 (see bug 14180). I have tried to check the checkbox with jQuery, but it doesn't work quite right - the checkbox is checked, but the checkouts don't load... I think this patch would improve things. Argh, I see now that this is already in 3.18. Sorry for the confusion. |