(In reply to Katrin Fischer from comment #0)

> Several libraries have asked to check the checkbox permanently, as it's
> annoying to redo the checkbox every morning or even several times during the
> day. 

I thought Bug 13196 fixed this?

Hi Owen, thx for the comment! I have left a comment on the other bug - it's not in 3.18.x and marking ths see also for now to see if it fixes the problem for the library.

I realized that the patch Owen pointed to is already in 3.18, but this is still a problem to the library - maybe because of restrictive cookie settings? In general it would be nice if there was an option to just always load and get rid of the checkbox for some libraires.

I would like a global preference to turn "always show checkouts" on or off.
It is not something we would want to select daily or per session or per staff person.

There is also an extra row below "specify due date" in checkout that reports the barcode that was last checked out.
If "always show" is turned on - this is no longer needed, as the information is displayed twice.

I would wish to have that associated with the "Always show" function so that it only appears if "always show" is turned off.
It uses up screen space we would rather use to see the last several items we checked out - and there is already room for only one or two rows to show unless the screen resolution is dialed up.

"Always show checkouts immediately" is an annoying feature for library professionals in circulation desk. This feature is against the "Five Laws of Library Science" Save the Time of the reader!!

Which reader do you want to save time for? The reader who wants to see the list of checkouts  right away or the reader who wants to have the page load quickly when there are hundreds of checkouts? The point of this bug is to make a new preference so you can have it either leave things the way they are now or return them to the way things were before the changes made by Bug 12550. A preference is the only way to give options to the various needs different librarians have expressed.

(In reply to Owen Leonard from comment #6)
> Which reader do you want to save time for? The reader who wants to see the
> list of checkouts  right away or the reader who wants to have the page load
> quickly when there are hundreds of checkouts? The point of this bug is to
> make a new preference so you can have it either leave things the way they
> are now or return them to the way things were before the changes made by Bug
> 12550. A preference is the only way to give options to the various needs
> different librarians have expressed.

After check out, library professionals have the tendency to check the list of books checked out. If the list hide , they have to click on the checkbox of ("Always show checkouts immediately").

when the library professional open Check out of a particular user, he has to click on "Always show checkouts immediately" option. this process is time consuming when good number of reader in que to check out the books.

(In reply to vimal kumar from comment #7)

> when the library professional open Check out of a particular user, he has to
> click on "Always show checkouts immediately" option. this process is time
> consuming

It sounds to me like this bug is exactly what you want: A way to make it so that "Always show checkouts immediately" is globally enabled without a checkbox.

(In reply to Agnes Rivers-Moore from comment #4)
> I would wish to have that associated with the "Always show" function so that
> it only appears if "always show" is turned off.
> It uses up screen space we would rather use to see the last several items we
> checked out - and there is already room for only one or two rows to show
> unless the screen resolution is dialed up.

A patch implementing this can be found at http://git.esilibrary.com/?p=koha-equinox.git;a=commitdiff;h=6d63573393b911444db599b1b2e2d5c680ee5a15. Perhaps this should be spun off into a separate bug?

We added this code on 'IntranetUserJS' syspref and it works perfectly for us :)
(Found on Biblibre's documentation)


$(document).ready(function() {
 
if ( typeof script !== 'undefined' && ! $.cookie("issues-table-load-immediately-" + script) ) {
    $.cookie("issues-table-load-immediately-" + script, true, { expires: 365 });
}
 
});

(In reply to Séverine Queune from comment #10)
> We added this code on 'IntranetUserJS' syspref and it works perfectly for us
> :)
> (Found on Biblibre's documentation)
> 
> 
> $(document).ready(function() {
>  
> if ( typeof script !== 'undefined' && !
> $.cookie("issues-table-load-immediately-" + script) ) {
>     $.cookie("issues-table-load-immediately-" + script, true, { expires: 365
> });
> }
>  
> });

Using Severine's workaround - marking WONTFIX.

I want to open this back up, please. I believe that this is worth talking about again.  A system preference would be optimal to allow libraries to turn on/off.

The IntranetUserJS syspref work around isn't working in Koha 22.05+ version.

(In reply to Marie-Luce Laflamme from comment #13)
> The IntranetUserJS syspref work around isn't working in Koha 22.05+ version.

The handling for cookies has changed, this appears to work on master:

$(document).ready(function() {
 
if (typeof script !== 'undefined' && Cookies.get("issues-table-load-immediately-" + script) !== "true") {
    Cookies.set("issues-table-load-immediately-" + script, true, { expires: 365, sameSite: 'Lax'  });
}
 
});

(In reply to Katrin Fischer from comment #14)
> (In reply to Marie-Luce Laflamme from comment #13)
> > The IntranetUserJS syspref work around isn't working in Koha 22.05+ version.
> 
> The handling for cookies has changed, this appears to work on master:
> 
> $(document).ready(function() {
>  
> if (typeof script !== 'undefined' &&
> Cookies.get("issues-table-load-immediately-" + script) !== "true") {
>     Cookies.set("issues-table-load-immediately-" + script, true, { expires:
> 365, sameSite: 'Lax'  });
> }
>  
> });


Your quick fix works well in 22.05 and the latest master version.

Thanks Kathrin

(In reply to Marie-Luce Laflamme from comment #15)
> (In reply to Katrin Fischer from comment #14)
> > (In reply to Marie-Luce Laflamme from comment #13)
> > > The IntranetUserJS syspref work around isn't working in Koha 22.05+ version.
> > 
> > The handling for cookies has changed, this appears to work on master:
> > 
> > $(document).ready(function() {
> >  
> > if (typeof script !== 'undefined' &&
> > Cookies.get("issues-table-load-immediately-" + script) !== "true") {
> >     Cookies.set("issues-table-load-immediately-" + script, true, { expires:
> > 365, sameSite: 'Lax'  });
> > }
> >  
> > });
> 
> 
> Your quick fix works well in 22.05 and the latest master version.
> 
> Thanks Kathrin

Thx for the feedback, happy it helped!

While it's great to have the js, it would be awesome if this could be a system preference.

Agreed on this. It would be nice if showing checkouts automatically would be a system preference.

+1 for making it a syspref the library can control, and that persists! We just had an upgrade and lost this work around again. For our library this is essential customer service - when staff check out we look for anything that's due soon and needs renewing. Also helps in self-checkout, that red overdue items show immediately. Thanks!

I agree, it would be a huge plus to have a system preference instead of using JS code.

This is a big request from our partner libraries; turning this into a system preference would be lovely. The JS is good to have on hand, but sometimes stops working after major releases.

Created attachment 161548 [details] [review]
Bug 14180: Perltidy

To test:
1. APPLY PATCH, updatedatebase, restart_all
2. Search for the system preference 'AlwaysLoadCheckoutsTable' and set it to 'Do'.
3. Go to 'circ/circulation.pl?borrowernumber=X' for a patron with checkouts. ( Check out tab ).
4. The table should load right away.
5. Go to 'members/moremember.pl?borrowernumber=X' for a patron with checkouts. ( Details tab ).
6. The table should load right way.
7. Set a value in the 'LoadCheckoutsTableDelay' system preference.
8. Back on 'circ/circulation.pl?borrowernumber=X', make sure the delay is honored. You should see a message like "Checkouts table will automatically load in X seconds".
9. The delay should NOT be honored on'members/moremember.pl?borrowernumber=X', that table should load right away/
10. Turn off 'AlwaysLoadCheckoutsTable' and make sure the table does not load, or loads according to the cookie set when checking the 'Always show checkouts automatically' checkbox.

Created attachment 161549 [details] [review]
Bug 14180: Add AlwaysLoadCheckoutsTable system preference

Created attachment 161550 [details] [review]
Bug 14180: Add option to always load the issues table

Created attachment 161551 [details] [review]
Bug 14180: Perltidy

To test:
1. APPLY PATCH, updatedatebase, restart_all
2. Search for the system preference 'AlwaysLoadCheckoutsTable' and set it to 'Do'.
3. Go to 'circ/circulation.pl?borrowernumber=X' for a patron with checkouts. ( Check out tab ).
4. The table should load right away.
5. Go to 'members/moremember.pl?borrowernumber=X' for a patron with checkouts. ( Details tab ).
6. The table should load right way.
7. Set a value in the 'LoadCheckoutsTableDelay' system preference.
8. Back on 'circ/circulation.pl?borrowernumber=X', make sure the delay is honored. You should see a message like "Checkouts table will automatically load in X seconds".
9. The delay should NOT be honored on'members/moremember.pl?borrowernumber=X', that table should load right away/
10. Turn off 'AlwaysLoadCheckoutsTable' and make sure the table does not load, or loads according to the cookie set when checking the 'Always show checkouts automatically' checkbox.

Created attachment 161554 [details] [review]
Bug 14180: Add AlwaysLoadCheckoutsTable system preference

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Created attachment 161555 [details] [review]
Bug 14180: Add option to always load the issues table

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Created attachment 161556 [details] [review]
Bug 14180: Perltidy

To test:
1. APPLY PATCH, updatedatebase, restart_all
2. Search for the system preference 'AlwaysLoadCheckoutsTable' and set it to 'Do'.
3. Go to 'circ/circulation.pl?borrowernumber=X' for a patron with checkouts. ( Check out tab ).
4. The table should load right away.
5. Go to 'members/moremember.pl?borrowernumber=X' for a patron with checkouts. ( Details tab ).
6. The table should load right way.
7. Set a value in the 'LoadCheckoutsTableDelay' system preference.
8. Back on 'circ/circulation.pl?borrowernumber=X', make sure the delay is honored. You should see a message like "Checkouts table will automatically load in X seconds".
9. The delay should NOT be honored on'members/moremember.pl?borrowernumber=X', that table should load right away/
10. Turn off 'AlwaysLoadCheckoutsTable' and make sure the table does not load, or loads according to the cookie set when checking the 'Always show checkouts automatically' checkbox.

Signed-off-by: Kelly <kelly@bywatersolutions.com>

This looks like maybe it should have been set to Signed Off when Kelly tested it 1/26. As of today, the patch doesn't apply.

(In reply to Andrew Fuerste-Henry from comment #29)
> This looks like maybe it should have been set to Signed Off when Kelly
> tested it 1/26. As of today, the patch doesn't apply.

Due to patches from Bug 35506 being pushed to master.

Created attachment 170095 [details] [review]
Bug 14180: Add AlwaysLoadCheckoutsTable system preference

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Created attachment 170096 [details] [review]
Bug 14180: Add option to always load the issues table

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Created attachment 170097 [details] [review]
Bug 14180: Add AlwaysLoadCheckoutsTable system preference

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Created attachment 170098 [details] [review]
Bug 14180: Add option to always load the issues table

To test:
 1. APPLY PATCH, updatedatebase, restart_all
 2. Search for the system preference 'AlwaysLoadCheckoutsTable' and set it to 'Do'.
 3. Go to 'circ/circulation.pl?borrowernumber=X' for a patron with checkouts. ( Check out tab ).
 4. The table should load right away.
 5. Go to 'members/moremember.pl?borrowernumber=X' for a patron with checkouts. ( Details tab ).
 6. The table should load right way.
 7. Set a value in the 'LoadCheckoutsTableDelay' system preference.
 8. Back on 'circ/circulation.pl?borrowernumber=X', make sure the delay is honored. You should see a message like "Checkouts table will automatically load in X seconds".
 9. The delay should NOT be honored on'members/moremember.pl?borrowernumber=X', that table should load right away/
10. Turn off 'AlwaysLoadCheckoutsTable' and make sure the table does not load, or loads according to the cookie set when checking the 'Always show checkouts automatically' checkbox.

Signed-off-by: Kelly <kelly@bywatersolutions.com>

Hi,
Can we get a QA for this please? It's very silly that we have to use jquery - this is a feature a lot of libraries need.

Yes please, this would be enormously helpful.

Created attachment 173382 [details] [review]
Bug 14180: Add AlwaysLoadCheckoutsTable system preference

Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Created attachment 173383 [details] [review]
Bug 14180: Add option to always load the issues table

To test:
 1. APPLY PATCH, updatedatebase, restart_all
 2. Search for the system preference 'AlwaysLoadCheckoutsTable' and set it to 'Do'.
 3. Go to 'circ/circulation.pl?borrowernumber=X' for a patron with checkouts. ( Check out tab ).
 4. The table should load right away.
 5. Go to 'members/moremember.pl?borrowernumber=X' for a patron with checkouts. ( Details tab ).
 6. The table should load right way.
 7. Set a value in the 'LoadCheckoutsTableDelay' system preference.
 8. Back on 'circ/circulation.pl?borrowernumber=X', make sure the delay is honored. You should see a message like "Checkouts table will automatically load in X seconds".
 9. The delay should NOT be honored on'members/moremember.pl?borrowernumber=X', that table should load right away/
10. Turn off 'AlwaysLoadCheckoutsTable' and make sure the table does not load, or loads according to the cookie set when checking the 'Always show checkouts automatically' checkbox.

Signed-off-by: Kelly <kelly@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Created attachment 173384 [details] [review]
Bug 14180: (QA follow-up) Re-arrange sysprefs to fix QA warnings

Not strictly related to this patchset, but showed up here.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

1) Database update

Please don't leave out the success line of the database update:

        say_success( $out, "Added new system preference 'AlwaysLoadCheckoutsTable'" );

Fixed on push.

2) System preferences

checksouts > checkouts 

Fixed in follow-up.

Pushed for 24.11!

Well done everyone, thank you!

Enhancement. No 24.05.x backport.