Summary: | Plugin housekeeping: UNIMARC field 123i, 123j, 210c | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Cataloging | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | jonathan.druart, m.de.rooy, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c
Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c [PASSED QA] Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c |
Description
Marcel de Rooy
2014-11-05 13:00:45 UTC
Created attachment 33245 [details] [review] Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c In working on bug 10480, I noticed that these plugins needed some attention: [2] unimarc_field_123i.pl: added missing template [3] unimarc_field_123j.pl: resolved missing template with same file [4] unimarc_field_210c_bis.pl: removed a warn, corrected some POD lines Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere). Test plan: Connect unimarc_field_123i and 123j to some field. Look especially at changing + or - for the hemisphere in the popup. (In reply to M. de Rooy from comment #1) > Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 > characters long and contain the same components as subfields $f and $g > except that character position 0 contains a plus sign (for the northern > celestial hemisphere) or a minus sign (for the southern celestial > hemisphere). I am not sure about that. From http://multimedia.bnf.fr/unimarcb_trad/B123-6-2010.pdf, $ij are declinaison and $fg are coordinate. Moreover the default value should be '00' not '', isn't it? (In reply to Jonathan Druart from comment #2) > (In reply to M. de Rooy from comment #1) > > Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 > > characters long and contain the same components as subfields $f and $g > > except that character position 0 contains a plus sign (for the northern > > celestial hemisphere) or a minus sign (for the southern celestial > > hemisphere). > > I am not sure about that. > From http://multimedia.bnf.fr/unimarcb_trad/B123-6-2010.pdf, $ij are > declinaison and $fg are coordinate. > Moreover the default value should be '00' not '', isn't it? My information came from ifla. You are correct that fg is coordinate and ij is declination. I do not understand the 00 ? (In reply to M. de Rooy from comment #3) > I do not understand the 00 ? If I don't fill the inputs, the value should be 00, not an empty string. Otherwise the field could be filled with a string's length < 8 Created attachment 33289 [details] [review] Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c In working on bug 10480, I noticed that these plugins needed some attention: [2] unimarc_field_123i.pl: added missing template [3] unimarc_field_123j.pl: resolved missing template with same file [4] unimarc_field_210c_bis.pl: removed a warn, corrected some POD lines Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere). Test plan: Connect unimarc_field_123i and 123j to some field. Look especially at changing + or - for the hemisphere in the popup. Check left-padding with zeroes for the other positions. (In reply to Jonathan Druart from comment #2) > Moreover the default value should be '00' not '', isn't it? Corrected. (In reply to M. de Rooy from comment #7) > (In reply to Jonathan Druart from comment #2) > > Moreover the default value should be '00' not '', isn't it? > > Corrected. 1 character is still missing. "A celestial chart with an angular scale, with declination -16° to -49°" is $i-0160000$j-0490000 With the patch, I get $i-016000$j-049000 Created attachment 33292 [details] [review] Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c In working on bug 10480, I noticed that these plugins needed some attention: [2] unimarc_field_123i.pl: added missing template [3] unimarc_field_123j.pl: resolved missing template with same file [4] unimarc_field_210c_bis.pl: removed a warn, corrected some POD lines Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere). Test plan: Connect unimarc_field_123i and 123j to some field. Look especially at changing + or - for the hemisphere in the popup. Check left-padding with zeroes for the other positions. (In reply to Jonathan Druart from comment #8) > (In reply to M. de Rooy from comment #7) > > (In reply to Jonathan Druart from comment #2) > > > Moreover the default value should be '00' not '', isn't it? > > > > Corrected. > > 1 character is still missing. > > "A celestial chart with an angular scale, with declination -16° to -49°" > is $i-0160000$j-0490000 > > With the patch, I get $i-016000$j-049000 Thanks for testing. Fixed a dumb typo: f3 = f3.substring(f2.length-2); f2->f3 What means "Degree (complete with 0):"? Does it should be 000 for degree and 00 for the 2 others? (In reply to Jonathan Druart from comment #11) > What means "Degree (complete with 0):"? > Does it should be 000 for degree and 00 for the 2 others? I just copied this from the existing unimarc_field_123g template. It actually means left padding with zeroes. I agree that this text is confusing. According to the specs, it is plus or minus followed by 3-2-2 chars (total 8). Created attachment 33299 [details] [review] Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c In working on bug 10480, I noticed that these plugins needed some attention: [2] unimarc_field_123i.pl: added missing template [3] unimarc_field_123j.pl: resolved missing template with same file [4] unimarc_field_210c_bis.pl: removed a warn, corrected some POD lines Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere). Test plan: Connect unimarc_field_123i and 123j to some field. Look especially at changing + or - for the hemisphere in the popup. Check left-padding with zeroes for the other positions. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 33347 [details] [review] [PASSED QA] Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c In working on bug 10480, I noticed that these plugins needed some attention: [2] unimarc_field_123i.pl: added missing template [3] unimarc_field_123j.pl: resolved missing template with same file [4] unimarc_field_210c_bis.pl: removed a warn, corrected some POD lines Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere). Test plan: Connect unimarc_field_123i and 123j to some field. Look especially at changing + or - for the hemisphere in the popup. Check left-padding with zeroes for the other positions. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. Checked plugin in a UNIMARC installation. Patch pushed to master. Thanks Marcel! |