Bug 13253

Summary: Unnecessary white space above checkouts table in circulation
Product: Koha Reporter: Owen Leonard <oleonard>
Component: CirculationAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: gmcharlt, kyle.m.hall, mtj, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 11703    
Bug Blocks:    
Attachments: Bug 13253 - Unnecessary white space above checkouts table in circulation
Bug 13253 - Unnecessary white space above checkouts table in circulation
[PASSED QA] Bug 13253 - Unnecessary white space above checkouts table in circulation

Description Owen Leonard 2014-11-14 01:14:11 UTC
The DataTables sDom configuration for the new AJAX circulation checkouts table contains some superfluous markup which pushes the checkouts table down. This distance can mean the difference, on some screens, between being able to see the last item checked out or not.
Comment 1 Owen Leonard 2014-11-14 01:51:28 UTC Comment hidden (obsolete)
Comment 2 Liz Rea 2014-11-14 02:55:30 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-11-14 05:35:54 UTC
Created attachment 33545 [details] [review]
[PASSED QA] Bug 13253 - Unnecessary white space above checkouts table in circulation

On the new checkouts page there is some padding above the checkouts,
relatives' checkouts, and holds tables caused by extra markup in the
table's sDom configuration (http://legacy.datatables.net/ref#sDom):

<'row-fluid'<'span6'><'span6'>r>t<'row-fluid'>t

This creates several empty <div>s which don't serve any purpose. This
patch simplifies it to:

rt

To test, apply the patch, clear your browser cache, and check out to a
patron who has items checked out, holds on their account, and child
records attached which also have checkouts.

The padding above the table of checkouts, the table of relatives'
checkouts, and the table of holds should match that on the sides.

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Checked per plan on both Check Out and Details pages, spacing appears correct.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.
Comment 4 Tomás Cohen Arazi 2014-11-14 12:36:37 UTC
Patch pushed to master.

Thanks Owen!
Comment 5 Mason James 2015-01-20 15:02:30 UTC
Pushed to 3.16.x, patch will be in 3.16.7