| Summary: | Add a warning when a course reserve is checked in | ||
|---|---|---|---|
| Product: | Koha | Reporter: | simith.doliveira |
| Component: | Circulation | Assignee: | Bugs List <koha-bugs> |
| Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P4 | CC: | catherine.dupuy-lenen, eric.begin, gmcharlt, kyle.m.hall, marjorie.barry-vila, martin.renvoize, philippe.blouin, tmisilo, veron |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | holds | ||
| Attachments: |
Add a warning during the return of a document that was reserved to a course
This patch adds the following warning during the return of a document that was reserved to a course: |
||
|
Description
simith.doliveira
2014-11-25 14:14:58 UTC
This patch adds the following warning during the return of a document that was reserved to a course: "Please return 'title' to the 'course name' class reserve." Testing: 1) Define a document as a course reserve see manual.koha-community.org/3.14/en/coursereserves.html 2) Checkout and checkin this document. Validade the warning Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Created attachment 33907 [details]
Add a warning during the return of a document that was reserved to a course
+ <div class="error dialog" style="text-align:center;margin-right:0px;margin:auto;"> There's no reason to define a new message style in this patch. <div class="dialog message"> works perfectly well here. The message text is not quite correct either. It refers to "class reserve" when the feature is called "course reserves." I would suggest something like "[ title ] is part of the [ course ] course reserve." That text is informational without being specifically directional. I think it's better not to use the term "return" which is expected to be seen in this context with regard to transfers between branches. Created attachment 36212 [details] [review] This patch adds the following warning during the return of a document that was reserved to a course: "Please return 'title' to the 'course name' class reserve." Testing: 1) Define a document as a course reserve see manual.koha-community.org/3.14/en/coursereserves.html 2) Checkout and checkin this document. Validade the warning The warning was changed to "[ title ] is part of the [ course ] course reserve." It works as expected on returns.pl However when I go to circulation.pl and check in using the button "Renow or check in selected items", I would expect a similar message as well (or some information in the "Checkouts" table e.g. in the column "Title") returns.pl was working as expected, but it was 10 years ago... The last comment asking for a similar message when checking in several items at once seems to have been discouraging. But still, the initial work is interesting, this is really a lack. Could at least this process go until the end or would it have to start all over again to match with the latest versions ? Hm, we do have the situation that when returning from the patron account directly, a lot of the alerts are not displaying, that would show on the normal returns page. I feel like this patch would not necessarily need to solve this. I am not sure if Simith is still around to fix this, but maybe someone would be willing to adopt it. Seems to still be of value, but our sponsor for this patch is not using it anymore. I do not see us (including simith) going back to it at this point. (In reply to Blou from comment #9) > Seems to still be of value, but our sponsor for this patch is not using it > anymore. I do not see us (including simith) going back to it at this point. Thanks for the quick reply, Blou. I have updated the Assignee to reflect this. I agree that a note on return would still be a nice thing. |