Bug 13334 - Add a warning when a course reserve is checked in
Summary: Add a warning when a course reserve is checked in
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P4 normal (vote)
Assignee: simith.doliveira
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-25 14:14 UTC by simith.doliveira
Modified: 2023-07-28 19:35 UTC (History)
7 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Add a warning during the return of a document that was reserved to a course (2.22 KB, text/plain)
2014-11-25 14:26 UTC, simith.doliveira
Details
This patch adds the following warning during the return of a document that was reserved to a course: (2.42 KB, patch)
2015-02-26 20:39 UTC, simith.doliveira
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description simith.doliveira 2014-11-25 14:14:58 UTC

    
Comment 1 simith.doliveira 2014-11-25 14:24:22 UTC
This patch adds the following warning during the return of a document that was reserved to a course:

"Please return 'title' to the 'course name' class reserve."  

Testing:

1) Define a document as a course reserve

see manual.koha-community.org/3.14/en/coursereserves.html

2) Checkout and checkin this document.
Validade the warning

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )
Comment 2 simith.doliveira 2014-11-25 14:26:21 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2014-11-26 18:58:15 UTC
+    <div class="error dialog" style="text-align:center;margin-right:0px;margin:auto;">

There's no reason to define a new message style in this patch. <div class="dialog message"> works perfectly well here.

The message text is not quite correct either. It refers to "class reserve" when the feature is called "course reserves."

I would suggest something like "[ title ] is part of the [ course ] course reserve." That text is informational without being specifically directional. I think it's better not to use the term "return" which is expected to be seen in this context with regard to transfers between branches.
Comment 4 simith.doliveira 2015-02-26 20:39:16 UTC
Created attachment 36212 [details] [review]
This patch adds the following warning during the return of a document that was reserved to a course:

"Please return 'title' to the 'course name' class reserve."

Testing:

1) Define a document as a course reserve

see manual.koha-community.org/3.14/en/coursereserves.html

2) Checkout and checkin this document.
Validade the warning
Comment 5 simith.doliveira 2015-02-26 20:41:34 UTC
The warning was changed to "[ title ] is part of the [ course ] course reserve."
Comment 6 Marc Véron 2015-03-01 19:00:02 UTC
It works as expected on returns.pl

However when I go to circulation.pl and check in using the button "Renow or check in selected items", I would expect a similar message as well (or some information in the "Checkouts" table e.g. in the column "Title")