Summary: | translate script creates dirs on update | ||
---|---|---|---|
Product: | Koha | Reporter: | Bernardo Gonzalez Kriegel <bgkriegel> |
Component: | I18N/L10N | Assignee: | Bernardo Gonzalez Kriegel <bgkriegel> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, f.demians, tomascohen |
Version: | 3.18 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 13362: translate script creates dirs on update
Bug 13362: translate script creates dirs on update [PASSED QA] Bug 13362: translate script creates dirs on update |
Description
Bernardo Gonzalez Kriegel
2014-11-28 18:12:11 UTC
Created attachment 34019 [details] [review] Bug 13362: translate script creates dirs on update A dir creation was uncommented (by me), the effect is create a lang dir on 'update', which is no needed. To test: 1) Update translation files for a uninstalled language (cd misc/translator; ./translate update xx-YY) 2) Check new dirs koha-tmpl/opac-tmpl/bootstrap/xx-YY/ koha-tmpl/intranet-tmpl/prog/xx-YY/ koha-tmpl/intranet-tmpl/prog/en/modules/help/xx-YY/ 3) Clean all git clean -f -d 4) Apply the patch 5) Repeat 1) (i.e. update) 6) Check no new dirs this time Created attachment 34020 [details] [review] Bug 13362: translate script creates dirs on update A dir creation was uncommented (by me), the effect is create a lang dir on 'update', which is no needed. To test: 1) Update translation files for a uninstalled language (cd misc/translator; ./translate update xx-YY) 2) Check new dirs koha-tmpl/opac-tmpl/bootstrap/xx-YY/ koha-tmpl/intranet-tmpl/prog/xx-YY/ koha-tmpl/intranet-tmpl/prog/en/modules/help/xx-YY/ 3) Clean all git clean -f -d 4) Apply the patch 5) Repeat 1) (i.e. update) 6) Check no new dirs this time Signed-off-by: Frederic Demians <f.demians@tamil.fr> Created attachment 34378 [details] [review] [PASSED QA] Bug 13362: translate script creates dirs on update A dir creation was uncommented (by me), the effect is create a lang dir on 'update', which is no needed. To test: 1) Update translation files for a uninstalled language (cd misc/translator; ./translate update xx-YY) 2) Check new dirs koha-tmpl/opac-tmpl/bootstrap/xx-YY/ koha-tmpl/intranet-tmpl/prog/xx-YY/ koha-tmpl/intranet-tmpl/prog/en/modules/help/xx-YY/ 3) Clean all git clean -f -d 4) Apply the patch 5) Repeat 1) (i.e. update) 6) Check no new dirs this time Signed-off-by: Frederic Demians <f.demians@tamil.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested according to test plan, works as described. Passes tests and QA script. Patch pushed to master. Good catch Bernardo! Pushed to 3.18.x will be in 3.18.2 |