Bug 13375

Summary: Syspref search highlight styling broken in Chrome
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: tomascohen
Version: 3.18   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Before the patch
After the patch
Bug 13375: Syspref search highlight styling broken in Chrome
Bug 13375 [Alternate] Syspref search highlight styling broken in Chrome
[SIGNED OFF] Bug 13375: Syspref search highlight styling broken in Chrome
[PASSED QA] Bug 13375: Syspref search highlight styling broken in Chrome

Description Tomás Cohen Arazi 2014-12-02 22:52:09 UTC
To reproduce:
- Do a syspref search, for example 'facet'.
=> FAIL: Some highlighted occurences of 'facet' have styling problems, check the attached screenshots.

Note: Firefox seems to render it properly, this is just in Chrome.
Comment 1 Tomás Cohen Arazi 2014-12-02 22:57:24 UTC
Created attachment 34075 [details]
Before the patch
Comment 2 Tomás Cohen Arazi 2014-12-02 22:57:43 UTC
Created attachment 34076 [details]
After the patch
Comment 3 Tomás Cohen Arazi 2014-12-02 22:59:35 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2014-12-03 13:45:21 UTC Comment hidden (obsolete)
Comment 5 Tomás Cohen Arazi 2014-12-03 14:25:42 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall 2014-12-05 14:58:02 UTC
Created attachment 34144 [details] [review]
[PASSED QA] Bug 13375: Syspref search highlight styling broken in Chrome

This patch encloses the the syspref description/values mix in a <div>.
It doesn't introduce any regression on other browsers (like Firefox) and
has the side effect to make Chrome render the highlighted words on
syspref searches well.

This alternate patch uses a <div> instead of a <span> because it will
sometimes contain block-level elements. Follow the same plan:

To test:
- Search for 'facet' on the sysprefs
=> FAIL: verify it has styling problems in Chrome
- Apply the patch, reload
=> SUCCESS: styling is correct

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2014-12-17 22:40:15 UTC
Patch pushed to master.

Thanks Owen!