| Summary: | Syspref search highlight styling broken in Chrome | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | tomascohen |
| Version: | 3.18 | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Before the patch
After the patch Bug 13375: Syspref search highlight styling broken in Chrome Bug 13375 [Alternate] Syspref search highlight styling broken in Chrome [SIGNED OFF] Bug 13375: Syspref search highlight styling broken in Chrome [PASSED QA] Bug 13375: Syspref search highlight styling broken in Chrome |
||
|
Description
Tomás Cohen Arazi (tcohen)
2014-12-02 22:52:09 UTC
Created attachment 34075 [details]
Before the patch
Created attachment 34076 [details]
After the patch
Created attachment 34077 [details] [review] Bug 13375: Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix into a <span>. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct - Sign off :-D Regards Created attachment 34092 [details] [review] Bug 13375 [Alternate] Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix in a <div>. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. This alternate patch uses a <div> instead of a <span> because it will sometimes contain block-level elements. Follow the same plan: To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct Created attachment 34093 [details] [review] [SIGNED OFF] Bug 13375: Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix in a <div>. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. This alternate patch uses a <div> instead of a <span> because it will sometimes contain block-level elements. Follow the same plan: To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Created attachment 34144 [details] [review] [PASSED QA] Bug 13375: Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix in a <div>. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. This alternate patch uses a <div> instead of a <span> because it will sometimes contain block-level elements. Follow the same plan: To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Owen! |