Summary: | Typo in marc21_leader.pl position 5 (record status) | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Cataloging | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | chris, m.de.rooy, mtj, tomascohen |
Version: | 3.16 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 13416: Typo in marc21_leader.pl position 5 (record status)
Bug 13416: Follow-up fix whitespace issues [SIGNED OFF] Bug 13416: Typo in marc21_leader.pl position 5 (record status) Bug 13416: Follow-up fix whitespace issues Bug 13416: Typo in marc21_leader.pl position 5 (record status) [PASSED QA] Bug 13416: Typo in marc21_leader.pl position 5 (record status) |
Description
Marcel de Rooy
2014-12-09 13:50:16 UTC
Created attachment 34217 [details] [review] Bug 13416: Typo in marc21_leader.pl position 5 (record status) Instead of a space in the leader on this position, it should be an a. Test plan: Use the popup to set position 5 to a (increase in encoding level). Check if this patch puts an a in that position of the leader. Created attachment 34446 [details] [review] Bug 13416: Follow-up fix whitespace issues First patch failed koha qa tests due to white space issues. This patch corrects it. TEST PLAN --------- 1) Apply first patch 2) run koha qa test tools -- fails line 19 and 21 3) apply this patch 4) run koha qa test tools -- passes I'll leave this as needing sign off, just so that Marcel can confirm this patch is good. Created attachment 34447 [details] [review] [SIGNED OFF] Bug 13416: Typo in marc21_leader.pl position 5 (record status) Instead of a space in the leader on this position, it should be an a. Test plan: 1) Log in to staff client 2) Find a record in the catalog 3) Edit the record 4) Click the on builder popup icon. 5) View the page source -- the option is " " for the 'a- Increase in encoding level' entry. It really should be 'a'. 6) Apply patch. 7) Repeat steps 1-5 -- the option should be 'a' this time. 8) Run koha qa test tools. -- Discovered it failed. Provided a patch to fix this. It does, however, solve the major problem of ' ' vs. 'a'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 34448 [details] [review] Bug 13416: Follow-up fix whitespace issues First patch failed koha qa tests due to white space issues. This patch corrects it. TEST PLAN --------- 1) Apply first patch 2) run koha qa test tools -- fails line 19 and 21 3) apply this patch 4) run koha qa test tools -- passes I'll leave this as needing sign off, just so that Marcel can confirm this patch is good. Created attachment 34452 [details] [review] Bug 13416: Typo in marc21_leader.pl position 5 (record status) Instead of a space in the leader on this position, it should be an a. Test plan: 1) Log in to staff client 2) Find a record in the catalog 3) Edit the record 4) Click the on builder popup icon. 5) View the page source -- the option is " " for the 'a- Increase in encoding level' entry. It really should be 'a'. 6) Apply patch. 7) Repeat steps 1-5 -- the option should be 'a' this time. 8) Run koha qa test tools. -- Discovered it failed. Provided a patch to fix this. It does, however, solve the major problem of ' ' vs. 'a'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Thanks, Mark. Caused by a tab. When I apply it again, it gets converted into spaces, and the second patch is no longer needed (and not working anymore). Created attachment 34520 [details] [review] [PASSED QA] Bug 13416: Typo in marc21_leader.pl position 5 (record status) Instead of a space in the leader on this position, it should be an a. Test plan: 1) Log in to staff client 2) Find a record in the catalog 3) Edit the record 4) Click the on builder popup icon. 5) View the page source -- the option is " " for the 'a- Increase in encoding level' entry. It really should be 'a'. 6) Apply patch. 7) Repeat steps 1-5 -- the option should be 'a' this time. 8) Run koha qa test tools. -- Discovered it failed. Provided a patch to fix this. It does, however, solve the major problem of ' ' vs. 'a'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described. Patch pushed to master. Thanks Marcel! String changes, held for 3.18.3 Pushed to 3.18.x will be in 3.18.3 Contains string changes, holding for 3.16.8 Pushed to 3.16.x, will be in 3.16.7 |