| Summary: | Facet links broken when collection code limit is used | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Barton Chittenden <barton> |
| Component: | Searching | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | dcook, gwilliams, jdemuth, jonathan.druart, kyle, p.thrasher, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23086 |
||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 13442 - Facet links broken when collection code limit is used
[Signed-off] Bug 13442 - Facet links broken when collection code limit is used [PASSED QA] Bug 13442 - Facet links broken when collection code limit is used |
||
|
Description
Barton Chittenden
2014-12-11 15:51:04 UTC
Created attachment 34331 [details] [review] Bug 13442 - Facet links broken when collection code limit is used Any search limits including a ccode will break the search facts. Test Plan: 1) Run an advanced search using a ccode limit 2) Try using any of the facet links of the left 3) Note they are broken 4) Apply this patch 5) Refresh the results 6) Note the facet links are no longer broken Note: I have not been able to reproduce this issue on my own test system, but have noted the problem on at least a dozen Koha servers. Created attachment 34594 [details] [review] [Signed-off] Bug 13442 - Facet links broken when collection code limit is used Any search limits including a ccode will break the search facts. Test Plan: 1) Run an advanced search using a ccode limit 2) Try using any of the facet links of the left 3) Note they are broken 4) Apply this patch 5) Refresh the results 6) Note the facet links are no longer broken Note: I have not been able to reproduce this issue on my own test system, but have noted the problem on at least a dozen Koha servers. I could not reproduce the bug either, but I saw it on the Bywater Demo (comment #1). Applied patch and tested facets, no problems found, signing off Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 34602 [details] [review] [PASSED QA] Bug 13442 - Facet links broken when collection code limit is used Any search limits including a ccode will break the search facts. Test Plan: 1) Run an advanced search using a ccode limit 2) Try using any of the facet links of the left 3) Note they are broken 4) Apply this patch 5) Refresh the results 6) Note the facet links are no longer broken Note: I have not been able to reproduce this issue on my own test system, but have noted the problem on at least a dozen Koha servers. I could not reproduce the bug either, but I saw it on the Bywater Demo (comment #1). Applied patch and tested facets, no problems found, signing off Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Can not reproduce the problem, but I can also not find a regression. Does this work if the facet contain a simple quote? Shelf location facets are breaking in exactly the same way. Does C4::Search::buildQuery need to be refactored? Bug 13812 - Facet links broken when shelf location limit is used. Does this target master? the 3.18.x branch? UTf-8 handling differs, a lot on each. (In reply to Tomás Cohen Arazi from comment #6) > Does this target master? the 3.18.x branch? UTf-8 handling differs, a lot on > each. Sorry, wrong but number :-D Kyle, could you please address Jonathan's concern? The double-quoted "ccode" URLs are being passed to the search results page /cgi-bin/koha/catalogue/detail.pl and breaking the "Return to results" link on that page. (In reply to Tomás Cohen Arazi from comment #6) > Does this target master? the 3.18.x branch? UTf-8 handling differs, a lot on > each. Yes, this targets master. As far as I know this isn't a UTF-8 related issue, but deals with quotes. I can't reproduce this in master. Search: http://intranet.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=au:%22De%20Paola,%20Tomie.%22 Creates: <a href="/cgi-bin/koha/catalogue/search.pl?q=ccl=au%3A" de%20paola%2c%20tomie."&limit="itype:AOF"" title="AOF">Adult Office</a> However... Search: http://192.168.1.61:2112/cgi-bin/koha/catalogue/search.pl?q=au:%22De%20Paola,%20Tomie%22 Creates: <a href="/cgi-bin/koha/catalogue/search.pl?q=ccl=au%3A%22De%20Paola%2C%20Tomie%22&sort_by=relevance_dsc&limit=itype:TEST" title="TEST">test</a> Which works just fine. I noticed the Bywater site is on 3.19.00.016, and I'm on 3.19.00.026, so maybe that makes a difference. Or perhaps there's a setting difference somewhere... but this is the same thing I noticed on http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812. The Bywater link has an extra space and all the letters are lowercased. Patch pushed to master. Thanks Kyle! I think this patch caused a regression which I've noted in #22344 (In reply to David Cook from comment #12) > I think this patch caused a regression which I've noted in #22344 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22344 |