| Summary: | Standardize the pagination class | ||
|---|---|---|---|
| Product: | Koha | Reporter: | paxed <pasi.kallinen> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | brendan, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 13464 - Standardize the pagination class
Bug 13464 - Standardize the pagination class Bug 13464 - Standardize the pagination class |
||
|
Description
paxed
2014-12-15 12:00:36 UTC
Created attachment 49385 [details] [review] Bug 13464 - Standardize the pagination class There are a few template which use a different wrapper class for the pagination links. These should be made consistent for a consistent style. To test, apply the patch and go to Administration -> Budgets. - On this page the pagination markup has been removed in favor of DataTables pagination. The budget tables were already sorted using DataTables, so having server-side pagination on top of that doesn't make sense. In Administration -> Class sources: - This page had pagination markup which was unused. In Authorities -> Authority search results: - Perform an authority search which will return more than one page of results. Confirm that the pagination links are correctly styled. In Search -> Item search: - Perform a search which will return more than one page of results. Confirm that the pagination links are correctly styled. Created attachment 49435 [details] [review] Bug 13464 - Standardize the pagination class There are a few template which use a different wrapper class for the pagination links. These should be made consistent for a consistent style. To test, apply the patch and go to Administration -> Budgets. - On this page the pagination markup has been removed in favor of DataTables pagination. The budget tables were already sorted using DataTables, so having server-side pagination on top of that doesn't make sense. In Administration -> Class sources: - This page had pagination markup which was unused. In Authorities -> Authority search results: - Perform an authority search which will return more than one page of results. Confirm that the pagination links are correctly styled. In Search -> Item search: - Perform a search which will return more than one page of results. Confirm that the pagination links are correctly styled. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 49465 [details] [review] Bug 13464 - Standardize the pagination class There are a few template which use a different wrapper class for the pagination links. These should be made consistent for a consistent style. To test, apply the patch and go to Administration -> Budgets. - On this page the pagination markup has been removed in favor of DataTables pagination. The budget tables were already sorted using DataTables, so having server-side pagination on top of that doesn't make sense. In Administration -> Class sources: - This page had pagination markup which was unused. In Authorities -> Authority search results: - Perform an authority search which will return more than one page of results. Confirm that the pagination links are correctly styled. In Search -> Item search: - Perform a search which will return more than one page of results. Confirm that the pagination links are correctly styled. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Since the funds are all displayed (and nobody complained), it makes sense to display all budgets. Pushed to Master - Should be in the May 2016 release. Thanks! |