| Summary: | Untranslatable log actions | ||
|---|---|---|---|
| Product: | Koha | Reporter: | paxed <pasi.kallinen> |
| Component: | I18N/L10N | Assignee: | Aleisha Amohia <aleisha> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | brendan, f.demians, jonathan.druart, julian.maurice, mtompset, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 15658 | ||
| Attachments: |
Bug 13474: Adding untranslatable log actions to viewlog.tt
Bug 13474: Adding untranslatable log actions to viewlog.tt Bug 13474: Adding untranslatable log actions to viewlog.tt Bug 13474: Adding untranslatable log actions to viewlog.tt Bug 13474: Adding untranslatable log actions to viewlog.tt |
||
|
Description
paxed
2014-12-17 09:20:10 UTC
Created attachment 46933 [details] [review] Bug 13474: Adding untranslatable log actions to viewlog.tt Please confirm this is the fix that you are looking for! I think this is a good start. However:
mtompset@debian:~/kohaclone$ git grep "[ ]logaction(" | cut -f2 -d":" | cut -f2 -d"," | cut -f2 -d"(" | sed -e "s#^ *##g" | sed -e "s#\"#'#g" | sort -u
'ADD'
'ADDCIRCMESSAGE'
'CHANGE PASS'
'CREATE'
'DELCIRCMESSAGE'
'DELETE'
'ISSUE'
'MODIFY'
'RENEW'
'RETURN'
'Run'
mtompset@debian:~/kohaclone$
[% BLOCK translate_log_action %]
[% SWITCH action %]
[% CASE 'ADD' %]Add
[% CASE 'DELETE' %]Delete
[% CASE 'MODIFY' %]Modify
[% CASE 'ISSUE' %]Checkout
[% CASE 'RETURN' %]Return
[% CASE 'CREATE' %]Create
[% CASE %][% action %]
[% END %]
[% END %]
SCRATCH PAD:
'ADDCIRCMESSAGE'
'CHANGE PASS'
'DELCIRCMESSAGE'
'RENEW'
'Run'
There is one more action missing: 'Run'.
Created attachment 47051 [details] [review] Bug 13474: Adding untranslatable log actions to viewlog.tt Added 'Run' Signed-off-by: Aleisha <aleishaamohia@hotmail.com> (In reply to Aleisha Amohia from comment #3) > Created attachment 47051 [details] [review] [review] > Bug 13474: Adding untranslatable log actions to viewlog.tt > > Added 'Run' > > Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Sorry, your case is wrong. The code is literally 'Run', not 'RUN'. Yes, I found that strange too. Created attachment 47073 [details] [review] Bug 13474: Adding untranslatable log actions to viewlog.tt Added 'Run' Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Created attachment 47272 [details] [review] Bug 13474: Adding untranslatable log actions to viewlog.tt Added 'Run' Signed-off-by: Aleisha <aleishaamohia@hotmail.com> (Amended to remove tab chars to make qa tools happy) Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 47331 [details] [review] Bug 13474: Adding untranslatable log actions to viewlog.tt Added 'Run' Signed-off-by: Aleisha <aleishaamohia@hotmail.com> (Amended to remove tab chars to make qa tools happy) Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to Master - Should be in the May 2016 Release. Thanks! Patch pushed to 3.22.x, will be in 3.22.5 This patch has been pushed to 3.20.x, will be in 3.20.10. |