Bug 13474

Summary: Untranslatable log actions
Product: Koha Reporter: paxed <pasi.kallinen>
Component: I18N/L10NAssignee: Aleisha Amohia <aleisha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: brendan, f.demians, jonathan.druart, julian.maurice, mtompset, veron
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 15658    
Attachments: Bug 13474: Adding untranslatable log actions to viewlog.tt
Bug 13474: Adding untranslatable log actions to viewlog.tt
Bug 13474: Adding untranslatable log actions to viewlog.tt
Bug 13474: Adding untranslatable log actions to viewlog.tt
Bug 13474: Adding untranslatable log actions to viewlog.tt

Description paxed 2014-12-17 09:20:10 UTC
Log actions "RENEW", "CHANGE PASS", "ADDCIRCMESSAGE" and "DELCIRCMESSAGE" are untranslatable, need to be added to translate_log_action block in viewlog.tt
Comment 1 Aleisha Amohia 2016-01-19 20:30:29 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2016-01-20 20:43:18 UTC
I think this is a good start. However:

mtompset@debian:~/kohaclone$ git grep "[         ]logaction(" | cut -f2 -d":" | cut -f2 -d"," | cut -f2 -d"(" | sed -e "s#^ *##g" | sed -e "s#\"#'#g" | sort -u

'ADD'
'ADDCIRCMESSAGE'
'CHANGE PASS'
'CREATE'
'DELCIRCMESSAGE'
'DELETE'
'ISSUE'
'MODIFY'
'RENEW'
'RETURN'
'Run'
mtompset@debian:~/kohaclone$

[% BLOCK translate_log_action %]
[%    SWITCH action %]
[%        CASE 'ADD'    %]Add
[%        CASE 'DELETE' %]Delete
[%        CASE 'MODIFY' %]Modify
[%        CASE 'ISSUE'  %]Checkout
[%        CASE 'RETURN' %]Return
[%        CASE 'CREATE' %]Create
[%        CASE %][% action %]
[%    END %]
[% END %]

SCRATCH PAD:
'ADDCIRCMESSAGE'
'CHANGE PASS'
'DELCIRCMESSAGE'
'RENEW'
'Run'

There is one more action missing: 'Run'.
Comment 3 Aleisha Amohia 2016-01-20 21:13:23 UTC Comment hidden (obsolete)
Comment 4 Mark Tompsett 2016-01-20 23:55:32 UTC
(In reply to Aleisha Amohia from comment #3)
> Created attachment 47051 [details] [review] [review]
> Bug 13474: Adding untranslatable log actions to viewlog.tt
> 
> Added 'Run'
> 
> Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

Sorry, your case is wrong. The code is literally 'Run', not 'RUN'. Yes, I found that strange too.
Comment 5 Aleisha Amohia 2016-01-21 01:05:47 UTC Comment hidden (obsolete)
Comment 6 Marc Véron 2016-01-25 17:35:11 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2016-01-27 11:13:45 UTC
Created attachment 47331 [details] [review]
Bug 13474: Adding untranslatable log actions to viewlog.tt

Added 'Run'

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>

(Amended to remove tab chars to make qa tools happy)
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 8 Brendan Gallagher 2016-02-24 03:20:23 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 9 Julian Maurice 2016-03-07 10:54:01 UTC
Patch pushed to 3.22.x, will be in 3.22.5
Comment 10 Frédéric Demians 2016-03-15 08:59:48 UTC
This patch has been pushed to 3.20.x, will be in 3.20.10.