Bug 15658 - Browse system logs: Add more actions to action filter list
Summary: Browse system logs: Add more actions to action filter list
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Marc Véron
QA Contact: Testopia
URL:
Keywords:
Depends on: 13474
Blocks:
  Show dependency treegraph
 
Reported: 2016-01-25 17:42 UTC by Marc Véron
Modified: 2017-06-14 22:05 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15658: Browse system logs: Add more actions to action filter list (1.82 KB, patch)
2016-01-25 18:05 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15658: Browse system logs: Add more actions to action filter list (1.94 KB, patch)
2016-01-25 20:22 UTC, Héctor Eduardo Castro Avalos
Details | Diff | Splinter Review
Bug 15658: Browse system logs: Add more actions to action filter list (2.02 KB, patch)
2016-01-27 11:15 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Véron 2016-01-25 17:42:41 UTC
The following actions are missing in the action filter list on cgi-bin/koha/tools/viewlog.pl:

'ADDCIRCMESSAGE'
'CHANGE PASS'
'DELCIRCMESSAGE'
'RENEW'
'Run'
Comment 1 Marc Véron 2016-01-25 18:05:50 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-01-25 20:22:05 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2016-01-27 11:15:15 UTC
Created attachment 47332 [details] [review]
Bug 15658: Browse system logs: Add more actions to action filter list

The following actions were missing in the action filter list on
cgi-bin/koha/tools/viewlog.pl:

'ADDCIRCMESSAGE'
'CHANGE PASS'
'DELCIRCMESSAGE'
'RENEW'
'Run'

To test:
- Apply patch
- Go to Tools > Logs (viewlog.pl)
- Verify that the actions appear in the list 'Actions'
- Verify that the new entries filter the list as appropriate (in
  combination with Modules: All or with a meaningful selection in
  list 'Modules')

Note for testing: You have to set a date in 'Display from' to get results

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Logs work as advertised, translated in bug 13474

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
"Run" could be more explicit.
Comment 4 Brendan Gallagher 2016-02-24 02:18:13 UTC
Pushed to Master - Should be in the May 2016 Release.  Thanks!
Comment 5 Julian Maurice 2016-03-07 10:54:08 UTC
Patch pushed to 3.22.x, will be in 3.22.5
Comment 6 Frédéric Demians 2016-03-15 09:00:02 UTC
This patch has been pushed to 3.20.x, will be in 3.20.10.