Summary: | Item Search feature gets datatables error and doesn't complete search | ||
---|---|---|---|
Product: | Koha | Reporter: | Liz Rea <liz> |
Component: | Searching | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, mtj, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 11425 | ||
Bug Blocks: | |||
Attachments: |
Bug 13476: Fix DataTables for the search items form
[Signed-off] Bug 13476: Fix DataTables for the search items form Bug 13476: Fix DataTables for the search items form Bug 13476: Fix DataTables for the search items form paging problem |
Description
Liz Rea
2014-12-18 01:44:41 UTC
I can confirm the bug on 3.18.1, the search is currently not working. Also confirmed on current master. Created attachment 34521 [details] [review] Bug 13476: Fix DataTables for the search items form This items form is broken since the upgrade to DataTables 1.10.2 (commit 954c2874d0d9ebfa2e910dcd4445010115fac329). The fnServerParams does not work anymore. Test plan: Go on catalogue/itemsearch.pl, launch a search and verify the data are correctly displayed in the table. Created attachment 34584 [details] [review] [Signed-off] Bug 13476: Fix DataTables for the search items form This items form is broken since the upgrade to DataTables 1.10.2 (commit 954c2874d0d9ebfa2e910dcd4445010115fac329). The fnServerParams does not work anymore. Test plan: Go on catalogue/itemsearch.pl, launch a search and verify the data are correctly displayed in the table. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 34596 [details] [review] Bug 13476: Fix DataTables for the search items form This items form is broken since the upgrade to DataTables 1.10.2 (commit 954c2874d0d9ebfa2e910dcd4445010115fac329). The fnServerParams does not work anymore. Test plan: Go on catalogue/itemsearch.pl, launch a search and verify the data are correctly displayed in the table. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Created attachment 34600 [details] [review] Bug 13476: Fix DataTables for the search items form This items form is broken since the upgrade to DataTables 1.10.2 (commit 954c2874d0d9ebfa2e910dcd4445010115fac329). The fnServerParams does not work anymore. Test plan: Go on catalogue/itemsearch.pl, launch a search and verify the data are correctly displayed in the table. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> The paging seems still a bit buggy, but this makes the feature usable again! Created attachment 34601 [details]
paging problem
Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.2 (In reply to Katrin Fischer from comment #7) > Created attachment 34601 [details] > paging problem Fixed by bug 13487. (In reply to Chris Cormack from comment #9) > Pushed to 3.18.x will be in 3.18.2 skipping patch for 3.16.x Thanks everybody. :) |