Bug 13496

Summary: Wrong Koha version on installer title
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: TemplatesAssignee: Tomás Cohen Arazi <tomascohen>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: tomascohen
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 13496: add a method for the templates to print Koha version as desired
Bug 13496: make auth.tt use a template plugin to get the Koha version
Bug 13496: add a method for the templates to print Koha version as desired
Bug 13496: make auth.tt use a template plugin to get the Koha version
[PASSED QA] Bug 13496: add a method for the templates to print Koha version as desired
[PASSED QA] Bug 13496: make auth.tt use a template plugin to get the Koha version

Description Tomás Cohen Arazi 2014-12-29 00:02:55 UTC
Steps to reproduce:

- Launch the webinstaller (I deleted my DB to do it)
- The login screen shows
=> FAIL: "Koha 3.0 Installer" is hidden inside the code. It seems to be intended for screen readers to tell it (I cannot test that feature) but I think it is showing the wrong version, and it shouldn't.
Comment 1 Tomás Cohen Arazi 2014-12-29 00:32:02 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2014-12-29 00:33:41 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2015-01-01 06:24:33 UTC Comment hidden (obsolete)
Comment 4 Chris Cormack 2015-01-01 06:24:50 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2015-01-02 16:02:49 UTC
Created attachment 34899 [details] [review]
[PASSED QA] Bug 13496: add a method for the templates to print Koha version as desired

This patch introduces a simple template plugin function that returns
the Koha version number in different suitable formats.

It introduces unit tests for the new function. They are run with

To test:
- Apply the patch
- Run
  $ prove t/Koha_Template_Plugin_Koha.t
=> SUCCESS: the tests pass.
- Sign off :-D

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2015-01-02 16:02:55 UTC
Created attachment 34900 [details] [review]
[PASSED QA] Bug 13496: make auth.tt use a template plugin to get the Koha version

This patch makes the installer login template use the new Koha.Version
template plugin to get the correct Koha version. This way we don't need
to maintain the auth.tt file on each version change, and are sure screen
readers tell the correct version.

To test:
- Create a situation where the login screen from the installer shows
- Navigate the HTML code (Ctrl+u)
=> FAIL: "Koha 3.0 Installer" shows on the HTML code
- Apply the patch
- Reload the page
=> SUCCESS: The correct version number is shown.
- Sign off :-D

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Tomás Cohen Arazi 2015-01-04 15:22:57 UTC
Patches pushed to master.