| Summary: | Bug 12969 introduces a test case that fails | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Robin Sheat <robin> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | jonathan.druart, paola.rossi, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12969 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 12969, 13275 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 13554: t/Prices.t shouldn't depend on the DB
Bug 13554: t/Prices.t shouldn't depend on the DB [PASSED QA] Bug 13554: t/Prices.t shouldn't depend on the DB |
||
Created attachment 35099 [details] [review] Bug 13554: t/Prices.t shouldn't depend on the DB To reproduce: - Stop your MySQL server: $ sudo service mysql stop - Run $ prove t/Prices.t => FAIL: some tests fail because of mysql stopped To test (MySQL still stopped) - Apply the patch - Run $ prove t/Prices.t Created attachment 35105 [details] [review] Bug 13554: t/Prices.t shouldn't depend on the DB I've applied this patch against master 3.19.00.005 head 12868. NB. the 13275 patch is an omnibus one. Everything's OK. I pass the patch to "Signed Off" status. Created attachment 35334 [details] [review] [PASSED QA] Bug 13554: t/Prices.t shouldn't depend on the DB To reproduce: - Stop your MySQL server: $ sudo service mysql stop - Run $ prove t/Prices.t => FAIL: some tests fail because of mysql stopped To test (MySQL still stopped) - Apply the patch - Run $ prove t/Prices.t Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks JOnathan! |
DBI connect('dbname=koha;host=localhost;port=3306','kohaadmin',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Context.pm line 785 Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Context.pm line 785. Compilation failed in require at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Letters.pm line 27. BEGIN failed--compilation aborted at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Letters.pm line 27. Compilation failed in require at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Suggestions.pm line 30. BEGIN failed--compilation aborted at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Suggestions.pm line 30. Compilation failed in require at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Acquisition.pm line 27. BEGIN failed--compilation aborted at /tmp/buildd/koha-3.19~git+20150112121205.483ad2ae/blib/PERL_MODULE_DIR/C4/Acquisition.pm line 27. Compilation failed in require at t/Prices.t line 5. BEGIN failed--compilation aborted at t/Prices.t line 5. # Looks like your test exited with 255 before it could output anything. t/Prices.t ..........................