| Summary: | Angular-based circulation client | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jesse Weaver <jweaver> |
| Component: | Circulation | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED WONTFIX | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | amy, black23, dcook, gmcharlt, gwilliams, jonathan.druart, kyle.m.hall, martin.renvoize, nick, nicole, tmisilo, tomascohen, viktor.sarge |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 | ||
| Change sponsored?: | --- | Patch complexity: | Large patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 12272, 13563 | ||
| Bug Blocks: | |||
| Attachments: | Bug 13630 - Basic Angular circulation client | ||
|
Description
Jesse Weaver
2015-01-27 20:08:08 UTC
Git repo? Awesome... This is a pretty massive piece of work me thinks... shall we get some team work going Jesse... are you following any style guidelines for your angular use? 1/ 51 files changed, 5515 insertions(+), 1722 deletions(-)
(11703 in it)
=> Should be split
2/ based on 3.16, need a rebase
3/ Squash please, ~40 commits
4/ Decent commit messages, with test plan
5/ Without test plan I had to git grep the code to know where circ/checkout.pl was called
6/ on circ/circulation.pl, More > Switch checkout client
Enter a barcode, click on the Check out button, nothing append:
500 Internal Server Error
in koha logs:
patrons: Can't use string ("1") as a HASH ref while "strict refs" in use at /home/koha/src/C4/Circulation.pm line 747.
Brendan gave me the angular-circ url yesterday, but https://github.com/pianohacker/koha/tree/angular-submit seems to be more recent. Jesse, could you confirm where is the work related to this bug report ? (In reply to Jonathan Druart from comment #6) > Brendan gave me the angular-circ url yesterday, but > https://github.com/pianohacker/koha/tree/angular-submit seems to be more > recent. > > Jesse, could you confirm where is the work related to this bug report ? Ah, yes, sorry. The angular-submit branch is more recent. Please provide a detailed test plan. This bug depends on bug 12272 and bug 13563, does the enh can be tested checking out the branch on github? Testing with the angular-submit branch: The checkout table looks broken and there are no action buttons (circ/checkout.pl), that means this patch adds a 3rd place where this table is defined. Maybe it could be good to refactor some code here. Still got the error 500. (In reply to Jonathan Druart from comment #9) > This bug depends on bug 12272 and bug 13563, does the enh can be tested > checking out the branch on github? > > Testing with the angular-submit branch: > The checkout table looks broken and there are no action buttons > (circ/checkout.pl), that means this patch adds a 3rd place where this table > is defined. Maybe it could be good to refactor some code here. > > Still got the error 500. Will get you a detailed test plan. We were working on fixing some issues with the checkouts datatable, but any permanent fix will likely depend on Kyle. Yes, the branch should be testable simply by checking out the Github branch. Created attachment 36262 [details] [review] Bug 13630 - Basic Angular circulation client Changed to 'needs signoff' since Jesse just attached a patch. Feel free to change back if that was inaccurate. Got this problem both in local git and sandbox: fatal: sha1 information is lacking or useless (Koha/Service.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 13630 - Basic Angular circulation client It might be an easy problem so I won't change the status of the bug, but it's also a problem that means I can't test it. Any updates welcome since I'm curious about testing this to see if it gives a performance boost :) Patch complexity is 'Large' because this change has many architectural connections fatal: sha1 information is lacking or useless (Koha/Service.pm). Closing this bug, AngularJS, which this is based on, is a dead project at this point. Out of interest, dead for Koha or in general? (In reply to Katrin Fischer from comment #17) > Out of interest, dead for Koha or in general? In general. Angular was renamed AngularJs and a new project is now named Angular which was a complete rewrite and is incompatible with the original Angular. (In reply to Kyle M Hall from comment #18) > (In reply to Katrin Fischer from comment #17) > > Out of interest, dead for Koha or in general? > > In general. Angular was renamed AngularJs and a new project is now named > Angular which was a complete rewrite and is incompatible with the original > Angular. More context: AngularJS (now only supported until 2021): https://github.com/angular/angular.js Move from AngularJS to Angular: https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c New Angular (Typescript-based complete-rewrite of AngularJS): https://github.com/angular/angular Thx for explaining! |