Bug 13630 - Angular-based circulation client
Summary: Angular-based circulation client
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 12272 13563
Blocks:
  Show dependency treegraph
 
Reported: 2015-01-27 20:08 UTC by Jesse Weaver
Modified: 2020-01-06 20:14 UTC (History)
14 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Large patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13630 - Basic Angular circulation client (71.69 KB, patch)
2015-03-02 06:22 UTC, Jesse Weaver
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Weaver 2015-01-27 20:08:08 UTC
This patch is an in-progress reimplementation of the checkin/checkout interfaces using AngularJS.
Comment 1 Tomás Cohen Arazi 2015-01-27 21:56:10 UTC
Git repo?
Comment 2 Martin Renvoize 2015-01-27 22:05:49 UTC
Awesome...
Comment 3 Martin Renvoize 2015-01-28 11:19:15 UTC
This is a pretty massive piece of work me thinks... shall we get some team work going Jesse... are you following any style guidelines for your angular use?
Comment 4 Jonathan Druart 2015-02-11 15:10:27 UTC
https://github.com/pianohacker/koha/tree/angular-circ
Comment 5 Jonathan Druart 2015-02-12 15:52:01 UTC
1/ 51 files changed, 5515 insertions(+), 1722 deletions(-)
(11703 in it)
=> Should be split

2/ based on 3.16, need a rebase

3/ Squash please, ~40 commits

4/ Decent commit messages, with test plan

5/ Without test plan I had to git grep the code to know where circ/checkout.pl was called

6/ on circ/circulation.pl, More > Switch checkout client
Enter a barcode, click on the Check out button, nothing append:
    500 Internal Server Error
in koha logs:
    patrons: Can't use string ("1") as a HASH ref while "strict refs" in use at /home/koha/src/C4/Circulation.pm line 747.
Comment 6 Jonathan Druart 2015-02-12 15:58:34 UTC
Brendan gave me the angular-circ url yesterday, but https://github.com/pianohacker/koha/tree/angular-submit seems to be more recent.

Jesse, could you confirm where is the work related to this bug report ?
Comment 7 Jesse Weaver 2015-02-12 21:10:33 UTC
(In reply to Jonathan Druart from comment #6)
> Brendan gave me the angular-circ url yesterday, but
> https://github.com/pianohacker/koha/tree/angular-submit seems to be more
> recent.
> 
> Jesse, could you confirm where is the work related to this bug report ?

Ah, yes, sorry. The angular-submit branch is more recent.
Comment 8 Jonathan Druart 2015-02-13 09:17:02 UTC
Please provide a detailed test plan.
Comment 9 Jonathan Druart 2015-02-13 09:24:07 UTC
This bug depends on bug 12272 and bug 13563, does the enh can be tested checking out the branch on github?

Testing with the angular-submit branch:
The checkout table looks broken and there are no action buttons (circ/checkout.pl), that means this patch adds a 3rd place where this table is defined. Maybe it could be good to refactor some code here.

Still got the error 500.
Comment 10 Jesse Weaver 2015-02-17 07:39:58 UTC
(In reply to Jonathan Druart from comment #9)
> This bug depends on bug 12272 and bug 13563, does the enh can be tested
> checking out the branch on github?
> 
> Testing with the angular-submit branch:
> The checkout table looks broken and there are no action buttons
> (circ/checkout.pl), that means this patch adds a 3rd place where this table
> is defined. Maybe it could be good to refactor some code here.
> 
> Still got the error 500.

Will get you a detailed test plan. We were working on fixing some issues with the checkouts datatable, but any permanent fix will likely depend on Kyle.

Yes, the branch should be testable simply by checking out the Github branch.
Comment 11 Jesse Weaver 2015-03-02 06:22:56 UTC
Created attachment 36262 [details] [review]
Bug 13630 - Basic Angular circulation client
Comment 12 Nicole C. Engard 2015-03-02 09:28:51 UTC
Changed to 'needs signoff' since Jesse just attached a patch. Feel free to change back if that was inaccurate.
Comment 13 Viktor Sarge 2015-05-22 11:58:52 UTC
Got this problem both in local git and sandbox: 

fatal: sha1 information is lacking or useless (Koha/Service.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.

Patch failed at 0001 Bug 13630 - Basic Angular circulation client



It might be an easy problem so I won't change the status of the bug, but it's also a problem that means I can't test it. Any updates welcome since I'm curious about testing this to see if it gives a performance boost :)
Comment 14 Zeno Tajoli 2015-09-01 08:31:01 UTC
Patch complexity is 'Large' because this change has many architectural connections
Comment 15 Nick Clemens 2015-11-17 22:05:04 UTC
fatal: sha1 information is lacking or useless (Koha/Service.pm).
Comment 16 Kyle M Hall 2019-02-06 16:00:44 UTC
Closing this bug, AngularJS, which this is based on, is a dead project at this point.
Comment 17 Katrin Fischer 2019-02-06 21:26:01 UTC
Out of interest, dead for Koha or in general?
Comment 18 Kyle M Hall 2019-02-06 22:02:26 UTC
(In reply to Katrin Fischer from comment #17)
> Out of interest, dead for Koha or in general?

In general. Angular was renamed AngularJs and a new project is now named Angular which was a complete rewrite and is incompatible with the original Angular.
Comment 19 David Cook 2019-02-07 00:23:29 UTC
(In reply to Kyle M Hall from comment #18)
> (In reply to Katrin Fischer from comment #17)
> > Out of interest, dead for Koha or in general?
> 
> In general. Angular was renamed AngularJs and a new project is now named
> Angular which was a complete rewrite and is incompatible with the original
> Angular.

More context:

AngularJS (now only supported until 2021): https://github.com/angular/angular.js

Move from AngularJS to Angular: https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c

New Angular (Typescript-based complete-rewrite of AngularJS): https://github.com/angular/angular
Comment 20 Katrin Fischer 2019-02-07 06:14:05 UTC
Thx for explaining!