Bug 13644

Summary: Paging Javascript breaks links with anchor
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Staff ClientAssignee: Bugs List <koha-bugs>
Status: CLOSED WORKSFORME QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: feli, gmcharlt, veron
Version: master   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937
Change sponsored?: --- Patch complexity: ---
Text to go in the release notes:
Version(s) released in:

Comment 1 Katrin Fischer 2015-01-30 09:38:30 UTC
I have a library asking me to put a link to the items tab of the MARC detail page on the normal detail page, so they can see the additional fields we have defined more easily. Trying to do this, turned up an oversight in the Javascript for the site paging.

In order for a link with an anchor # to work, the anchor needs to be last on the link, but the browser.js will but the searchid= parameter at the end, so the link is broken.

What needs to be done is to add the params directly after the other params and leave the #anchor at the end.

Line 101
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet-tmpl/js/browser.js;hb=ac3f497f64c1854a275fe894c1070f5888c1c302#l99

I have found no existing link that gets broken yet, but we could still fix this to make sure everywhere this script is used the links are created correctly.

Example:

Created link:
cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=130462#tab10XX&searchid=scs_1422610556359

Working link:
cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=130462&searchid=scs_1422610556359#tab10XX
Comment 2 Katrin Fischer 2015-01-30 10:20:28 UTC
It would be nice if the script was a bit more clever, but I figured out a workaround.
Comment 3 Katrin Fischer 2019-02-10 10:25:33 UTC
I can't replicate this on master anymore.