Bug 13644 - Paging Javascript breaks links with anchor
Summary: Paging Javascript breaks links with anchor
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff Client (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-30 09:36 UTC by Katrin Fischer
Modified: 2020-01-06 20:17 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Katrin Fischer 2015-01-30 09:38:30 UTC
I have a library asking me to put a link to the items tab of the MARC detail page on the normal detail page, so they can see the additional fields we have defined more easily. Trying to do this, turned up an oversight in the Javascript for the site paging.

In order for a link with an anchor # to work, the anchor needs to be last on the link, but the browser.js will but the searchid= parameter at the end, so the link is broken.

What needs to be done is to add the params directly after the other params and leave the #anchor at the end.

Line 101
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet-tmpl/js/browser.js;hb=ac3f497f64c1854a275fe894c1070f5888c1c302#l99

I have found no existing link that gets broken yet, but we could still fix this to make sure everywhere this script is used the links are created correctly.

Example:

Created link:
cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=130462#tab10XX&searchid=scs_1422610556359

Working link:
cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=130462&searchid=scs_1422610556359#tab10XX
Comment 2 Katrin Fischer 2015-01-30 10:20:28 UTC
It would be nice if the script was a bit more clever, but I figured out a workaround.
Comment 3 Katrin Fischer 2019-02-10 10:25:33 UTC
I can't replicate this on master anymore.