Summary: | ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type | ||
---|---|---|---|
Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
Component: | Web services | Assignee: | Julian Maurice <julian.maurice> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gwilliams, kyle.m.hall, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 13687: Move hold policy check into CanItemBeReserved
Bug 13687: Move hold policy check into CanItemBeReserved [PASSED QA] Bug 13687: Move hold policy check into CanItemBeReserved [PASSED QA] Bug 13687: Move hold policy check into CanItemBeReserved |
Description
Julian Maurice
2015-02-10 13:03:25 UTC
Created attachment 35777 [details] [review] Bug 13687: Move hold policy check into CanItemBeReserved This way ILS-DI HoldItem and HoldTitle services also benefit from this check Test plan: 1/ Define some default holds policies by item type in /admin/smart-rules.pl 2/ Use ILS-DI HoldItem service and check that those rules are respected 3/ Check that staff and opac hold behaviour is unchanged regarding these rules. Created attachment 36014 [details] [review] Bug 13687: Move hold policy check into CanItemBeReserved This way ILS-DI HoldItem and HoldTitle services also benefit from this check Test plan: 1/ Define some default holds policies by item type in /admin/smart-rules.pl 2/ Use ILS-DI HoldItem service and check that those rules are respected 3/ Check that staff and opac hold behaviour is unchanged regarding these rules. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 36336 [details] [review] [PASSED QA] Bug 13687: Move hold policy check into CanItemBeReserved This way ILS-DI HoldItem and HoldTitle services also benefit from this check Test plan: 1/ Define some default holds policies by item type in /admin/smart-rules.pl 2/ Use ILS-DI HoldItem service and check that those rules are respected 3/ Check that staff and opac hold behaviour is unchanged regarding these rules. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. No regressions found, improves the ILS-DI HoldItem response. The patch doesn't apply. Please consider taking a look at bug 5786 on rebasing. Created attachment 38398 [details] [review] [PASSED QA] Bug 13687: Move hold policy check into CanItemBeReserved Rebased on master Patch pushed to master. Thanks Julian! |