|
Description
Kyle M Hall (khall)
2015-02-11 12:27:15 UTC
Created attachment 35829 [details] [review] Bug 13696 - Add support for Font Awesome icons in Koha Font Awesome is similar to Glyphicons included in Twitter Bootstrap, except better in every way and more Free. Test Plan: 1) Apply this patch 2) Edit the template for a page, and add a Font Awesome tag to it, examples can be found here: http://fortawesome.github.io/Font-Awesome/examples/ 3) Reload the page and verify the icon displays. Created attachment 35881 [details]
Screenshot showing before and after
Looks like it's not quite a drop-in replacement. I'd like to see more testing done to see why things look off-kilter.
Owen, Are you doing the testing? I'm not sure what I'm seeing on this that's off kilter except that the bottom buttons are smaller. Nicole Nice Icons. Is it possible to get kind of testig patch for a template just to see how it works, e.g. to reproduce Owens's screenshot? Created attachment 36432 [details] [review] Bug 13636 SAMPLE: Add support for Font Awesome icons in Koha This is just a sample file, not part of the enhancement. Changing members-toolbar.inc to FontAwesome icons (fixed width). Created attachment 36433 [details] [review] Bug 13636 SAMPLE: Add support for Font Awesome icons in Koha This is just a sample file, not part of the enhancement. Changing members-toolbar.inc to FontAwesome icons (fixed width). http://bugs.koha-community.org/show_bug.cgi?id=13696 Bug 13636 SAMPLE: Add support for Font Awesome icons in Koha Some more icons changed Created attachment 36434 [details] [review] Bug 13696 - Add support for Font Awesome icons in Koha Font Awesome is similar to Glyphicons included in Twitter Bootstrap, except better in every way and more Free. Test Plan: 1) Apply this patch 2) Edit the template for a page, and add a Font Awesome tag to it, examples can be found here: http://fortawesome.github.io/Font-Awesome/examples/ 3) Reload the page and verify the icon displays. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Patch works as promised. I came across these icons some time ago and wondered if we could use them in Koha, nice enhancement! This is not supposed to invalidate Owen's concerns, just confirming that using the icons on a page works for me. I am hesitating about adding those without an idea on how we plan to make use of them. Why are they more free? License of Glyphicons: http://glyphicons.com/license/ License of Font-Awesome: http://fortawesome.github.io/Font-Awesome/license/ Kyle, what's the plan here? How will we use these fonts? (In reply to Katrin Fischer from comment #9) > Why are they more free? (In reply to Jonathan Druart from comment #11) > Kyle, what's the plan here? > How will we use these fonts? ping? The idea is just to give us more options for icons. We don't need to replace the glyphicons wholesale once this is in Koha, but we could certainly migrate away from them over time! Created attachment 42916 [details] [review] Bug 13696: Add new pref IconTheme This will permit to choose the icon theme to use: Glyphicons (default) or Font-Awesome. Created attachment 42917 [details] [review] Bug 13696: Pass the classes to use for icons to the templates Trying to unblock this bug report: I have submitted 2 new patches, they insert a new pref 'IconTheme' which can be changed from Glyphicons to Font-Awasome. All the icons used should be impacted by this change. Was it the idea behind this? (In reply to Jonathan Druart from comment #16) > Trying to unblock this bug report: > I have submitted 2 new patches, they insert a new pref 'IconTheme' which can > be changed from Glyphicons to Font-Awasome. > All the icons used should be impacted by this change. > > Was it the idea behind this? That is not necessary! Glyphicons and Font-Awesome can be used side-by-side within Koha. There is no need to make this an either-or proposition! The primary reason to add support for Font-Awesome is that it is far more powerful than Glyphicons, and is also FOSS, unlike Glyphicons. If we add support for Font Awesome to Koha, then we can, over time, replace our current usage of Glyphicons with Font Awesome until we are no longer using Glyphicons at all. So why don't we replace them? I don't see the point to integrate them into Koha if we don't use it. I agree we should replace them! (In reply to Jonathan Druart from comment #18) > So why don't we replace them? > I don't see the point to integrate them into Koha if we don't use it. Ok! Let's do it! Bug 14915 switches the staff side to Font Awesome icons. I will file another patch for the opac side! I think this can go back to signed off now! Created attachment 42931 [details] [review] Bug 13696 [QA Followup] - Add Font Awesome license to the about page Created attachment 42933 [details] [review] Bug 13696 - Add support for Font Awesome icons in Koha Font Awesome is similar to Glyphicons included in Twitter Bootstrap, except better in every way and more Free. Test Plan: 1) Apply this patch 2) Edit the template for a page, and add a Font Awesome tag to it, examples can be found here: http://fortawesome.github.io/Font-Awesome/examples/ 3) Reload the page and verify the icon displays. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 42934 [details] [review] Bug 13696 [QA Followup] - Add Font Awesome license to the about page Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> IMO this should be pushed with bug 14915, or we should comment the change in koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc and koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc for the next release. Created attachment 44012 [details] [review] Bug 13696 [QA Followup] - Update FA to 4.4.0 Created attachment 44037 [details] [review] [PASSED QA] Bug 13696 - Add support for Font Awesome icons in Koha Font Awesome is similar to Glyphicons included in Twitter Bootstrap, except better in every way and more Free. Test Plan: 1) Apply this patch 2) Edit the template for a page, and add a Font Awesome tag to it, examples can be found here: http://fortawesome.github.io/Font-Awesome/examples/ 3) Reload the page and verify the icon displays. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 44038 [details] [review] [PASSED QA] Bug 13696 [QA Followup] - Add Font Awesome license to the about page Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 44039 [details] [review] [PASSED QA] Bug 13696 [QA Followup] - Update FA to 4.4.0 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patches pushed to master. Good job Kyle! |