Summary: | Hide toolbar when printing a list page | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Lists | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | brendan, m.de.rooy, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 13761 - Hide toolbar when printing a list page
Bug 13761 - Hide toolbar when printing a list page |
Description
Fridolin Somers
2015-02-25 16:44:08 UTC
Created attachment 36170 [details] [review] Bug 13761 - Hide toolbar when printing a list page When printing a list page at Intranet, the toolbar is useless. This patch add #searchheader to print.css. It will hide at print the toolbar in several pages : catalogue/results.tt members/member.tt patron_lists/list.tt patroncards/members-search.tt serials/member-search.tt virtualshelves/shelves.tt Test plan : - Try to print the page (you can use print preview) - Check the toolbar is missing Hi Fridolin, I'd like to hide such stuff in print too. But with this approach, the H1 title disppears as well. It contains important information about the list, e.g. catalogue/results.tt: 621 result(s) found for 'kw,wrdl: mus'. member.tt: Results found for patron on street address fields containing ha I think it would be better to use the existing class 'noprint' for elements that are not intended to appear in print. E.g. in catalogue/results.tt line 309 for div selection_ops: class="cartlist noprint" instead of class="cartlist" What do you think about? Created attachment 44713 [details] [review] Bug 13761 - Hide toolbar when printing a list page When printing a list page at Intranet, the toolbar is useless. Test plan : - Try to print the page (you can use print preview) - Check the toolbar is missing (In reply to Marc Véron from comment #2) > > I think it would be better to use the existing class 'noprint' for elements > that are not intended to appear in print. > > E.g. in catalogue/results.tt line 309 for div selection_ops: > class="cartlist noprint" instead of class="cartlist" > > What do you think about? 100% agree, in fact this bug only manages list page. Here is the new patch Sorry, patch does not apply. CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt |