Bug 13761 - Hide toolbar when printing a list page
Summary: Hide toolbar when printing a list page
Status: RESOLVED DUPLICATE of bug 13986
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-25 16:44 UTC by Fridolin Somers
Modified: 2015-12-02 12:42 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13761 - Hide toolbar when printing a list page (1.07 KB, patch)
2015-02-25 16:49 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 13761 - Hide toolbar when printing a list page (1.11 KB, patch)
2015-11-10 15:31 UTC, Fridolin Somers
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2015-02-25 16:44:08 UTC
When printing a list page at Intranet, the toolbar is useless.
Hide it in print.css.
Comment 1 Fridolin Somers 2015-02-25 16:49:49 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2015-02-26 06:09:13 UTC
Hi Fridolin,

I'd like to hide such stuff in print too.

But with this approach, the H1 title disppears as well. It contains important information about the list, e.g.

catalogue/results.tt:
621 result(s) found for 'kw,wrdl: mus'.

member.tt:
Results found for patron on street address fields containing ha

I think it would be better to use the existing class 'noprint' for elements that are not intended to appear in print.

E.g. in catalogue/results.tt line 309 for div selection_ops: 
class="cartlist noprint" instead of class="cartlist"

What do you think about?
Comment 3 Fridolin Somers 2015-11-10 15:31:55 UTC
Created attachment 44713 [details] [review]
Bug 13761 - Hide toolbar when printing a list page

When printing a list page at Intranet, the toolbar is useless.

Test plan :
- Try to print the page (you can use print preview)
- Check the toolbar is missing
Comment 4 Fridolin Somers 2015-11-10 15:34:54 UTC
(In reply to Marc Véron from comment #2)
> 
> I think it would be better to use the existing class 'noprint' for elements
> that are not intended to appear in print.
> 
> E.g. in catalogue/results.tt line 309 for div selection_ops: 
> class="cartlist noprint" instead of class="cartlist"
> 
> What do you think about?

100% agree, in fact this bug only manages list page.

Here is the new patch
Comment 5 Marc Véron 2015-11-10 15:58:28 UTC
Sorry, patch does not apply.

CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
Comment 6 Fridolin Somers 2015-12-02 12:42:15 UTC
This has been corrected by Bug 13986
Cool :D

*** This bug has been marked as a duplicate of bug 13986 ***