Summary: | Readonly::XS (1:02) is not installed | ||
---|---|---|---|
Product: | Koha | Reporter: | Isabela Terra <isabelaterra> |
Component: | Searching | Assignee: | Mark Tompsett <mtompset> |
Status: | CLOSED INVALID | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | jonathan.druart, mtompset, veron |
Version: | Main | ||
Hardware: | PC | ||
OS: | Linux | ||
See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14066 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 |
||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 13767: Fix Readonly::XS version detection
Bug 13767: Fix Readonly::XS version detection Bug 13767: Fix Readonly::XS version detection Bug 13767: Fix Readonly::XS version detection Bug 13767: Fix Readonly::XS version detection [Signed-off] Bug 13767: Fix Readonly::XS version detection |
Description
Isabela Terra
2015-02-27 14:34:04 UTC
It has been annoying me too, Isabela. However, this is not a problem to really worry about if: $ dpkg -l libreadonly-xs-perl displays a version higher than 1.02, which you (and I) both have. Created attachment 38521 [details] [review] Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools For non-debian systems lacking a /usr/bin/dpkg, the output would be identical since the version number variable is left undefined, which is true for the criteria used for the missing logic. dpkg -l libreadonly-xs-perl Gewünscht=Unbekannt/Installieren/R=Entfernen/P=Vollständig Löschen/Halten | Status=Nicht/Installiert/Config/U=Entpackt/halb konFiguriert/ Halb installiert/Trigger erWartet/Trigger anhängig |/ Fehler?=(kein)/R=Neuinstallation notwendig (Status, Fehler: GROSS=schlecht) ||/ Name Version Architektur Beschreibung +++-==================================-======================-======================-========================================================================= ii libreadonly-xs-perl 1.04-2+b3 amd64 Faster Readonly implementation Staff client > About Koha without patch: Koha : About without patch: Readonly::XS (1.02) 1.04 Staff client > About Koha with patch: Readonly::XS (1.02) Not Installed Created attachment 38526 [details] [review] Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools For non-debian systems lacking a /usr/bin/dpkg, the output would be identical since the version number variable is left undefined, which is true for the criteria used for the missing logic. Created attachment 38527 [details] [review] Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools For non-debian systems lacking a /usr/bin/dpkg, the output would be identical since the version number variable is left undefined, which is true for the criteria used for the missing logic. Results with new patch: dpkg -l libreadonly-xs-perl Result: ii libreadonly-xs-perl 1.04-2+b3 amd64 Faster Readonly implementation Staff client > About Koha without patch Readonly::XS (1.02) 1.04 Staff client > About Koha with patch Readonly::XS (1.02) 1.04 The result is now the same with and without patch. To test what happens if libreadonly-xs-perl is not installed, I did: apt-get remove libreadonly-xs-perl On the about page, I get now: Readonly::XS (1.02) | [nothing in column for version number] I would expect: Readonly::XS (1.02) | Not installed Still looking for a nicer way. Created attachment 38528 [details] [review] Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools For non-debian systems lacking a /usr/bin/dpkg, the output would be identical since the version number variable is left undefined, which is true for the criteria used for the missing logic. Created attachment 38531 [details] [review] Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools All systems running Koha will have perldoc installed. :) Created attachment 38532 [details] [review] [Signed-off] Bug 13767: Fix Readonly::XS version detection The about.pl screen is unable to see that version 1.05-1+b1 is installed because eval "require Readonly::XS" returns an error message telling you that you can't use Readonly::XS directly. Since it is the only one, we attempt to use /usr/bin/dpkg to determine the version number. TEST PLAN --------- 1) $ dpkg -l libreadonly-xs-perl -- note the version number 2) Log in to staff client 3) About Koha -> Perl modules -- note it says Readonly::XS is not installed. -- note the versions and colours of the other modules. 4) Apply patch 5) Reload page and go to Perl modules tab -- Readonly::XS should list the version noted in step 1. -- the other modules' output should be unchanged. 6) Run koha qa test tools All systems running Koha will have perldoc installed. :) ---- Tested with an without Readonly::XS 1.04 installed. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> When QAing this patch, I was wondering why we used Readonly and Readonly::XS. And actually I did not find valid reasons. I have opened bug 14066 to remove these packages. If valided, it will invalid this one. I think Jonathan's solution of removing the dependency is better. :) I just tweaked up his solution on bug 14066. Feel free to test it and sign off. :) Bug 14066 passed QA, and I believe Katrin has gotten the remaining tiny pieces we missed all cleaned up. Once pushed to master, this should be resolved/closed. This was properly fixed and pushed to master by bug 14066. |