Bug 13767 - Readonly::XS (1:02) is not installed
Summary: Readonly::XS (1:02) is not installed
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: master
Hardware: PC Linux
: P5 - low minor (vote)
Assignee: Mark Tompsett
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-27 14:34 UTC by Isabela Terra
Modified: 2016-09-11 19:19 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 13767: Fix Readonly::XS version detection (3.73 KB, patch)
2015-04-27 01:36 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 13767: Fix Readonly::XS version detection (3.56 KB, patch)
2015-04-27 05:52 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 13767: Fix Readonly::XS version detection (3.70 KB, patch)
2015-04-27 06:43 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 13767: Fix Readonly::XS version detection (3.42 KB, patch)
2015-04-27 07:32 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 13767: Fix Readonly::XS version detection (3.29 KB, patch)
2015-04-27 07:36 UTC, Mark Tompsett
Details | Diff | Splinter Review
[Signed-off] Bug 13767: Fix Readonly::XS version detection (3.52 KB, patch)
2015-04-27 07:53 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Isabela Terra 2015-02-27 14:34:04 UTC
I'm really looking for some help here, please, my brain (whatever is left!) Is swimming in Perl code.

All perl modules are present (except tells me que Readonly :: XS (1:02) is not installed, but I have 1.05), permissions Have Been verified, ps -u koha shows the daemon and zebrasrv running, mysqlcheck is clean, etc.

Searches return empty and analytical reports report that is registered in the database.

I'm using Debian 7 u3 and Koha 3.18.
Comment 1 Mark Tompsett 2015-04-27 01:35:30 UTC
It has been annoying me too, Isabela. However, this is not a problem to really worry about if:

$ dpkg -l libreadonly-xs-perl

displays a version higher than 1.02, which you (and I) both have.
Comment 2 Mark Tompsett 2015-04-27 01:36:25 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2015-04-27 05:29:05 UTC
dpkg -l libreadonly-xs-perl

Gewünscht=Unbekannt/Installieren/R=Entfernen/P=Vollständig Löschen/Halten
| Status=Nicht/Installiert/Config/U=Entpackt/halb konFiguriert/
         Halb installiert/Trigger erWartet/Trigger anhängig
|/ Fehler?=(kein)/R=Neuinstallation notwendig (Status, Fehler: GROSS=schlecht)
||/ Name                               Version                Architektur            Beschreibung
+++-==================================-======================-======================-=========================================================================
ii  libreadonly-xs-perl                1.04-2+b3              amd64                  Faster Readonly implementation

Staff client > About Koha without patch:
Koha : About without patch:
Readonly::XS (1.02) 	1.04 

Staff client > About Koha with patch:
Readonly::XS (1.02) 	Not Installed
Comment 4 Mark Tompsett 2015-04-27 05:52:16 UTC Comment hidden (obsolete)
Comment 5 Mark Tompsett 2015-04-27 06:43:34 UTC Comment hidden (obsolete)
Comment 6 Marc Véron 2015-04-27 06:55:44 UTC
Results with new patch:

dpkg -l libreadonly-xs-perl
Result:
ii  libreadonly-xs-perl  1.04-2+b3  amd64 Faster Readonly implementation

Staff client > About Koha without patch
Readonly::XS (1.02) 	1.04 

Staff client > About Koha with patch
Readonly::XS (1.02) 	1.04 

The result is now the same with and without patch.
Comment 7 Marc Véron 2015-04-27 07:05:10 UTC
To test what happens if libreadonly-xs-perl is not installed, I did:

apt-get remove libreadonly-xs-perl

On the about page, I get now:
Readonly::XS (1.02) | [nothing in column for version number]

I would expect:
Readonly::XS (1.02) | Not installed
Comment 8 Mark Tompsett 2015-04-27 07:15:59 UTC
Still looking for a nicer way.
Comment 9 Mark Tompsett 2015-04-27 07:32:51 UTC Comment hidden (obsolete)
Comment 10 Mark Tompsett 2015-04-27 07:36:56 UTC Comment hidden (obsolete)
Comment 11 Marc Véron 2015-04-27 07:53:28 UTC
Created attachment 38532 [details] [review]
[Signed-off] Bug 13767: Fix Readonly::XS version detection

The about.pl screen is unable to see that version 1.05-1+b1 is
installed because eval "require Readonly::XS" returns an error
message telling you that you can't use Readonly::XS directly.

Since it is the only one, we attempt to use /usr/bin/dpkg to
determine the version number.

TEST PLAN
---------
1) $ dpkg -l libreadonly-xs-perl
   -- note the version number
2) Log in to staff client
3) About Koha -> Perl modules
   -- note it says Readonly::XS is not installed.
   -- note the versions and colours of the other modules.
4) Apply patch
5) Reload page and go to Perl modules tab
   -- Readonly::XS should list the version noted in step 1.
   -- the other modules' output should be unchanged.
6) Run koha qa test tools

All systems running Koha will have perldoc installed. :)

----
Tested with an without Readonly::XS 1.04 installed. Works as expected.

Signed-off-by: Marc Véron <veron@veron.ch>
Comment 12 Jonathan Druart 2015-04-27 11:42:11 UTC
When QAing this patch, I was wondering why we used Readonly and Readonly::XS.
And actually I did not find valid reasons.
I have opened bug 14066 to remove these packages. If valided, it will invalid this one.
Comment 13 Mark Tompsett 2015-04-27 22:57:15 UTC
I think Jonathan's solution of removing the dependency is better. :)
I just tweaked up his solution on bug 14066. Feel free to test it and sign off. :)
Comment 14 Mark Tompsett 2015-05-06 03:13:30 UTC
Bug 14066 passed QA, and I believe Katrin has gotten the remaining tiny pieces we missed all cleaned up. Once pushed to master, this should be resolved/closed.
Comment 15 Mark Tompsett 2015-05-06 15:19:30 UTC
This was properly fixed and pushed to master by bug 14066.