| Summary: | Full serial permission is needed to change sequence on a routing list | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Serials | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris, colin.campbell, tomascohen, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 13890 - Switch from full serials permission to 'routing' permission for reordering routing lists
[Signed-off] Bug 13890 - Switch from full serials permission to 'routing' permission for reordering routing lists [PASSED QA] Bug 13890 - Switch from full serials permission to 'routing' permission for reordering routing lists |
||
Created attachment 37096 [details] [review] Bug 13890 - Switch from full serials permission to 'routing' permission for reordering routing lists For changing the sequence of patrons on a routing list by changing one of the numbers via the pull downs, full serial permission is needed: To test: - Give your patron full serial permissions - Create a subscription and a routing list for it - Change the sequence on the routing list using the pull downs - Verify this works - Remove any of the serial sub permissions (claim serials or similar) - Verify changing the sequence now results in a permission error - Apply patch - Verify that the permission error is gone now - Remove the routing permission - Verify the permission error is back (but this seems to make sense) In general more fixes would be required to make all routing related features depend on the routing permission, but I think this fixes the bug making it depend on the correct permission. Created attachment 37099 [details] [review] [Signed-off] Bug 13890 - Switch from full serials permission to 'routing' permission for reordering routing lists For changing the sequence of patrons on a routing list by changing one of the numbers via the pull downs, full serial permission is needed: To test: - Give your patron full serial permissions - Create a subscription and a routing list for it - Change the sequence on the routing list using the pull downs - Verify this works - Remove any of the serial sub permissions (claim serials or similar) - Verify changing the sequence now results in a permission error - Apply patch - Verify that the permission error is gone now - Remove the routing permission - Verify the permission error is back (but this seems to make sense) In general more fixes would be required to make all routing related features depend on the routing permission, but I think this fixes the bug making it depend on the correct permission. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Created attachment 37309 [details] [review] [PASSED QA] Bug 13890 - Switch from full serials permission to 'routing' permission for reordering routing lists For changing the sequence of patrons on a routing list by changing one of the numbers via the pull downs, full serial permission is needed: To test: - Give your patron full serial permissions - Create a subscription and a routing list for it - Change the sequence on the routing list using the pull downs - Verify this works - Remove any of the serial sub permissions (claim serials or similar) - Verify changing the sequence now results in a permission error - Apply patch - Verify that the permission error is gone now - Remove the routing permission - Verify the permission error is back (but this seems to make sense) In general more fixes would be required to make all routing related features depend on the routing permission, but I think this fixes the bug making it depend on the correct permission. Followed test plan. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. Thanks Katrina! Pushed to 3.18.x will be in 3.18.6 |
For changing the sequence of patrons on a routing list by changing one of the numbers via the pull downs, full serial permission is needed: reorder_members.pl: checkauth( $query, 0, { serials => 1 }, 'intranet' ); To test: - Give your patron full serial permissions - Create a subscription and a routing list for it - Change the sequence on the routing list using the pull downs - Verify this works - Remove any of the serial sub permissions - Verify changing the sequence now results in a permission error