Bug 13945

Summary: Multiple dialogs for item that needs transferred and hold captured at checkin
Product: Koha Reporter: Kyle M Hall (khall) <kyle>
Component: CirculationAssignee: Laura Escamilla <Laura.escamilla>
Status: Pushed to oldstable --- QA Contact: Kyle M Hall (khall) <kyle>
Severity: minor    
Priority: P5 - low CC: david, fridolin.somers, gmcharlt, jdemuth, kyle.m.hall, Laura.escamilla, lucas, martin.renvoize, veron
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17101
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
This fixes multiple dialog boxes from popping up when checking in an item that has a hold, but needs transferred. Example: If an item is checked in at library A, and the item needs transferred to library B, *and* there is a hold for pickup at library B, the librarian will see a dialog box for both the transfer and the hold.
Version(s) released in:
24.11.00,24.05.06
Circulation function:
Attachments: Screenshot
Bug 13945: Prevent multiple dialog modals from popping up when capturing a hold at checkin
Bug 13945: Prevent multiple dialog modals from popping up when capturing a hold at checkin
Bug 13945: Prevent multiple dialog modals from popping up when capturing a hold at checkin

Description Kyle M Hall (khall) 2015-04-02 14:08:31 UTC
Created attachment 37440 [details]
Screenshot

If an item is checked in at library A, and the item needs transferred to library B, *and* there is a hold trapped for pickup at library B, the librarian will see a dialog both for the transfer, and for the hold.
Comment 1 Laura Escamilla 2024-05-15 15:37:31 UTC
Created attachment 166785 [details] [review]
Bug 13945: Prevent multiple dialog modals from popping up when capturing a hold at checkin

1. Select/Create Library Branches:
    - Select or create two library branches: Library A and Library B.

2. Locate/Create Item:
    - Locate or create an item with the "Current library" and "Home library" set to Library A.

3. Place Hold:
    - Place a hold on the item for a patron whose pickup location is Library B.

4. Check-in at Library A - First Attempt:
    - Check in the item at Library A.
    - Verify that the 'Hold found' modal pops up.
    - Click on 'Confirm hold and transfer'.

5. Check-in at Library A - Second Attempt:
    - Check in the item at Library A again.
    - Verify that the 'Hold found' modal pops up.
    - Click on 'Ignore'.
    - Verify that the 'Please return this item to (Library B)' modal has popped up behind it.

6. Apply Patch and Restart:
    - Apply the patch to the system.
    - Restart all relevant services.

7. Repeat Check-in Process:
    - Repeat steps 4 and 5.
    - Verify that no matter how many times you check in the item and hit 'Ignore' or 'Confirm the hold', the second modal does not pop up.
Comment 2 David Nind 2024-05-16 01:11:10 UTC
Created attachment 166801 [details] [review]
Bug 13945: Prevent multiple dialog modals from popping up when capturing a hold at checkin

1. Select/Create Library Branches:
    - Select or create two library branches: Library A and Library B.

2. Locate/Create Item:
    - Locate or create an item with the "Current library" and "Home library" set to Library A.

3. Place Hold:
    - Place a hold on the item for a patron whose pickup location is Library B.

4. Check-in at Library A - First Attempt:
    - Check in the item at Library A.
    - Verify that the 'Hold found' modal pops up.
    - Click on 'Confirm hold and transfer'.

5. Check-in at Library A - Second Attempt:
    - Check in the item at Library A again.
    - Verify that the 'Hold found' modal pops up.
    - Click on 'Ignore'.
    - Verify that the 'Please return this item to (Library B)' modal has popped up behind it.

6. Apply Patch and Restart:
    - Apply the patch to the system.
    - Restart all relevant services.

7. Repeat Check-in Process:
    - Repeat steps 4 and 5.
    - Verify that no matter how many times you check in the item and hit 'Ignore' or 'Confirm the hold', the second modal does not pop up.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-05-16 01:13:08 UTC
Testing notes (using KTD):

1. For step 5, I had to repeat the check in to get the 'Please return this item to (Library B)' modal to appear. In general, it appeared every second check in.
Comment 4 Kyle M Hall (khall) 2024-10-04 16:43:11 UTC
Created attachment 172420 [details] [review]
Bug 13945: Prevent multiple dialog modals from popping up when capturing a hold at checkin

1. Select/Create Library Branches:
    - Select or create two library branches: Library A and Library B.

2. Locate/Create Item:
    - Locate or create an item with the "Current library" and "Home library" set to Library A.

3. Place Hold:
    - Place a hold on the item for a patron whose pickup location is Library B.

4. Check-in at Library A - First Attempt:
    - Check in the item at Library A.
    - Verify that the 'Hold found' modal pops up.
    - Click on 'Confirm hold and transfer'.

5. Check-in at Library A - Second Attempt:
    - Check in the item at Library A again.
    - Verify that the 'Hold found' modal pops up.
    - Click on 'Ignore'.
    - Verify that the 'Please return this item to (Library B)' modal has popped up behind it.

6. Apply Patch and Restart:
    - Apply the patch to the system.
    - Restart all relevant services.

7. Repeat Check-in Process:
    - Repeat steps 4 and 5.
    - Verify that no matter how many times you check in the item and hit 'Ignore' or 'Confirm the hold', the second modal does not pop up.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Katrin Fischer 2024-10-11 10:27:30 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-11-18 23:00:34 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 7 Fridolin Somers 2024-12-11 14:52:03 UTC
Because it is the very important return page,
I prefer not to backport on oldoldstable 23.11.x even in case of side-effects