Bug 17101 - Confirm a question before check in
Summary: Confirm a question before check in
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low new feature with 10 votes (vote)
Assignee: Tobias Reimann
QA Contact: Testopia
URL:
Keywords:
: 14525 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-08-10 11:16 UTC by Tobias Reimann
Modified: 2019-04-26 13:50 UTC (History)
9 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 17101 - Confirm a question before check in (6.57 KB, patch)
2016-08-12 15:35 UTC, Tobias Reimann
Details | Diff | Splinter Review
Bug 17101 - Confirm a question before check in (6.70 KB, patch)
2016-08-12 15:45 UTC, Tobias Reimann
Details | Diff | Splinter Review
Bug 17101 - Confirm a question before check in (6.69 KB, patch)
2016-08-12 16:31 UTC, Mirko Tietgen
Details | Diff | Splinter Review
Bug 17101 - Style up 1 (2.65 KB, patch)
2016-08-12 16:45 UTC, Tobias Reimann
Details | Diff | Splinter Review
Bug 17101 - Style up 2 (2.10 KB, patch)
2016-08-12 17:14 UTC, Tobias Reimann
Details | Diff | Splinter Review
Bug 17101 - Style up (2.30 KB, patch)
2016-08-12 17:29 UTC, Tobias Reimann
Details | Diff | Splinter Review
Bug 17101 - Style Up fix (2.91 KB, patch)
2016-08-14 08:56 UTC, Tobias Reimann
Details | Diff | Splinter Review
Problem with workflow if hold found (34.54 KB, image/png)
2016-08-16 07:27 UTC, Marc Véron
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Reimann 2016-08-10 11:16:39 UTC
Here should be a new option for checkin message by itemtypes implemented. This new option required a confirmation from the user (over a question which is written there) bevor the item is checked in. The only possible answer for the question are yes or no. By yes the item is checked in, by no it's not checked in. 
To give an example what is meant here: If you create the item type audiobook, you then can add the Check in Message : "Does envelope and content match?" and for the check in message type: question. So if now a item with the item type audiobook is checked in, the user is ask : "Does envelope and content match?" and got the answer possibiltys yes and no. At this moment he can't read a new barcode, so he must answer the question. If he answer yes the item is check in, if he answer no the item is not check in.
Comment 1 Tobias Reimann 2016-08-12 15:35:40 UTC Comment hidden (obsolete)
Comment 2 Tobias Reimann 2016-08-12 15:45:37 UTC Comment hidden (obsolete)
Comment 3 Mirko Tietgen 2016-08-12 16:31:32 UTC
Created attachment 54386 [details] [review]
Bug 17101 - Confirm a question before check in

This patch enable the checkin message type question. This type ask the user before the item is check in, yes or no. Only if he click yes then the item is checked in.

Test plan:

1. Create an itemtype, with the checkinmsgtype question
2. Create an item with the itemtype from 1
3. Check out the item from 2
4. Check in the item from 3
5. Click no ==> item shouldn't be check in
6. Check in the item from 3
7. Click yes ==> item should be check in

Optional:
Before step 4 check others item in, to check if the prevouis check in's are still shown.

Sponsored-by: Bücherei Maichingen
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Comment 4 Mirko Tietgen 2016-08-12 16:33:24 UTC
Followed the testplan, works for me.

It would be nice to have some kind of message about not checking in the item after hitting cancel.
Comment 5 Tobias Reimann 2016-08-12 16:45:41 UTC Comment hidden (obsolete)
Comment 6 Tobias Reimann 2016-08-12 17:14:22 UTC Comment hidden (obsolete)
Comment 7 Tobias Reimann 2016-08-12 17:29:43 UTC Comment hidden (obsolete)
Comment 8 Mirko Tietgen 2016-08-13 12:14:43 UTC
With the second patch, I see a message when the item was not checked in, but there are no messages anymore for the other options besides "Question".
Comment 9 Tobias Reimann 2016-08-14 08:56:17 UTC
Created attachment 54425 [details] [review]
Bug 17101 - Style Up fix

This patch enable a message for the user after he hit no, by the
question in the check in window. Fixed the bug that no other message are displayed

        (new) Test plan:

        1. Create an itemtype, with the checkinmsgtype question
        2. Create an item with the itemtype from 1
        3. Check out the item from 2
        4. Check in the item from 3
        5. Click no ==> item shouldn't be check in and a message should be displ
ayed
        6. Check in the item from 3
        7. Click yes ==> item should be check in
ed

        Optional:
        Before step 4 check others item in, to check if the prevouis check in's
        Sponsored-by: Bücherei Maichingen
Comment 10 Marc Véron 2016-08-16 07:27:45 UTC
Created attachment 54495 [details]
Problem with workflow if hold found

There is a problem with the workflow if a hold is found. What should users do first first, confirm hold etc. or confirm question?

Confirming hold leads to an internal server error, plack error log says: Fatal: unexpected operator 'cancellationdate' with undef operand at ....Koha/Objects.pm line 1
Comment 11 Marc Véron 2016-08-16 18:30:52 UTC
Internal server error when confirming might be related to Bug 16942
See IRC: 
http://irc.koha-community.org/koha/2016-08-16#i_1849391

Regarding the work flow: It is confusing to have two things to confirm. Maybe two steps are better:

First the question about checking in and only after confirming this question the qeustion about holds.

What do you think about?
Comment 12 Marc Véron 2016-08-19 06:37:34 UTC
Added Bug 8451 as related ("Confusing and problematic double prompt for processing transfers")

Setting to "In Discussion" because the whole check in process needs clarification.
See:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8451#c10
Comment 13 Katrin Fischer 2016-09-20 11:51:27 UTC
Can we get this moving again? Maybe put it on the agenda of the next dev meeting?
Comment 14 Tobias Reimann 2016-09-25 09:52:56 UTC
Hey,

to solve the problem with the order of the information i would suggest following solution:

Only one message is shown to the user. 
The message with the highest priority, is shown first. When it was handeln the next massage is shown.

Following priority order should be made:

1. Question
2. Holds
3. Transportation ( only if not treated by holds)

Feel free to disscuss it.
Comment 15 Katrin Fischer 2016-10-16 13:20:10 UTC
Sounds good to me.
Comment 16 Lisette Scheer 2017-07-05 21:43:32 UTC
That seems like the correct order to me.
Comment 17 Joy Nelson 2019-02-16 15:09:07 UTC
*** Bug 14525 has been marked as a duplicate of this bug. ***