|
Description
Robin Sheat
2015-04-10 02:31:59 UTC
Created attachment 37787 [details] [review] Bug 13979: updates to allow installation on jessie Created attachment 37788 [details] [review] Bug 13979: [3.18.x] updates to allow installation on jessie Created attachment 37789 [details] [review] Bug 13979: [3.16.x] updates to allow installation on jessie Comment on attachment 37787 [details] [review] Bug 13979: updates to allow installation on jessie Review of attachment 37787 [details] [review]: ----------------------------------------------------------------- It eyeballs well, just one question... ::: debian/rules @@ +24,5 @@ > $(TMP)/usr/share/koha/intranet/htdocs/intranet-tmpl/lib/tiny_mce > ln -s /usr/share/tinymce/www \ > $(TMP)/usr/share/koha/intranet/htdocs/intranet-tmpl/lib/tiny_mce > +# ln -s /usr/share/javascript/yui \ > +# $(TMP)/usr/share/koha/opac/htdocs/opac-tmpl/lib/yui Why did you comment this one, but the other two you expressly deleted? Created attachment 37844 [details] [review] Bug 13979: updates to allow installation on jessie I think that bit commented was just a legacy from when I was experimenting, and the others didn't have it because I had to resolve conflicts to get it to apply so cleared it out. Created attachment 37900 [details] [review] [SIGNED-OFF] Bug 13979: [3.16.x] updates to allow installation on jessie Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 37901 [details] [review] [SIGNED-OFF] Bug 13979: [3.18.x] updates to allow installation on jessie Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 37902 [details] [review] [SIGNED-OFF] Bug 13979: updates to allow installation on jessie Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 38098 [details] [review] [PASSED QA] Bug 13979: updates to allow installation on jessie This patch makes the build script keep the shipped YUI JavaScript library instead of explicitly deleting it and using the one the operating system provides. Development is done against the YUI library we ship, so this makes sense even if Debian still shipped it. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Created attachment 38099 [details] [review] [PASSED QA] Bug 13979: [3.18.x] updates to allow installation on jessie This patch makes the build script keep the shipped YUI JavaScript library instead of explicitly deleting it and using the one the operating system provides. Development is done against the YUI library we ship, so this makes sense even if Debian still shipped it. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Created attachment 38100 [details] [review] [PASSED QA] Bug 13979: [3.16.x] updates to allow installation on jessie This patch makes the build script keep the shipped YUI JavaScript library instead of explicitly deleting it and using the one the operating system provides. Development is done against the YUI library we ship, so this makes sense even if Debian still shipped it. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Patch pushed to master. Thanks Robin! Pushed to 3.18.x will be in 3.18.6 Pushed to 3.16.x, will be in 3.16.11 |