| Summary: | SQLHelper replacement - C4::Members::Search - nl-search.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle, magnus, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 12633 | ||
| Attachments: |
Bug 14038: Make nl-search.pl not using C4::Members::Search
Bug 14038: Make nl-search.pl not using C4::Members::Search [PASSED QA] Bug 14038: Make nl-search.pl not using C4::Members::Search |
||
|
Description
Jonathan Druart
2015-04-22 08:18:36 UTC
Created attachment 38306 [details] [review] Bug 14038: Make nl-search.pl not using C4::Members::Search To get rid of SQLHelper, we should not use this C4::Members::Search anymore. Test plan for Magnus :) 0/ Enable the pref you need to use the Norwegian national library card ft 1/ Go on the members/nl-search.pl page and search for patrons. 2/ Make sure you search by card number and by "social security number" Created attachment 38665 [details] [review] Bug 14038: Make nl-search.pl not using C4::Members::Search To get rid of SQLHelper, we should not use this C4::Members::Search anymore. Test plan for Magnus :) 0/ Enable the pref you need to use the Norwegian national library card ft 1/ Go on the members/nl-search.pl page and search for patrons. 2/ Make sure you search by card number and by "social security number" Signed-off-by: Magnus Enger <magnus@enger.priv.no> Searching works the same with and without the patch. Thanks Jonathan! QA team: This patch can only really be tested by a Norwegian library system vendor, because you need all sorts of passwords and secret handshakes... I think what can be done is testing for regressions, e.g. that normal patron search works as expected with NorwegianPatronDBEnable = Disable. Created attachment 38694 [details] [review] [PASSED QA] Bug 14038: Make nl-search.pl not using C4::Members::Search To get rid of SQLHelper, we should not use this C4::Members::Search anymore. Test plan for Magnus :) 0/ Enable the pref you need to use the Norwegian national library card ft 1/ Go on the members/nl-search.pl page and search for patrons. 2/ Make sure you search by card number and by "social security number" Signed-off-by: Magnus Enger <magnus@enger.priv.no> Searching works the same with and without the patch. Thanks Jonathan! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Code touched by this patch is specific to the Norwegian library card feature - no regressions found and trusting Magnus as a tester here (have to... ;) ) Patch pushed to master. Thanks Jonathan! |