Summary: | Missing de-DE DISCHARGE message | ||
---|---|---|---|
Product: | Koha | Reporter: | Bernardo Gonzalez Kriegel <bgkriegel> |
Component: | Patrons | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | gmcharlt, kyle.m.hall, mtompset, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 14119: Missing de-DE DISCHARGE message
Bug 14119: Missing de-DE DISCHARGE message Bug 14119 - Missing de-DE DISCHARGE message (German wording) [SIGNED_OFF] Bug 14119 - Missing de-DE DISCHARGE message (German wording) Bug 14119: Missing de-DE DISCHARGE message Bug 14119 - Missing de-DE DISCHARGE message (German wording) [PASSED QA] Bug 14119: Missing de-DE DISCHARGE message [PASSED QA] Bug 14119 - Missing de-DE DISCHARGE message (German wording) |
Description
Bernardo Gonzalez Kriegel
2015-05-02 02:36:57 UTC
Created attachment 38760 [details] [review] Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. If a German patch is provided, please reset assignee :) I will sign. This works, but I rather a German counter patch. :) Created attachment 38761 [details] [review] Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> As noted, a German counter patch is preferred. :) Created attachment 38765 [details] [review] Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors Created attachment 38766 [details] [review] [SIGNED_OFF] Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Right wording :) Fixed version First patch obsoleted Comment on attachment 38761 [details] [review] Bug 14119: Missing de-DE DISCHARGE message It looks like the second patch requires the first. Unchecking 'obsolete' for a clean apply. Created attachment 38770 [details] [review] Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> As noted, a German counter patch is preferred. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Required for a clean install of German patch. Created attachment 38771 [details] [review] Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Right wording :) Fixed version Signed-off-by: Mark Tompsett <mtompset@hotmail.com> German version. YAY! Created attachment 38784 [details] [review] [PASSED QA] Bug 14119: Missing de-DE DISCHARGE message This patch adds DISCHARGE sample message to de-DE sample_notices.pl To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors As original Bug 8007 sample message this is not translated, so a German counter patch is welcome. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> As noted, a German counter patch is preferred. :) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 38785 [details] [review] [PASSED QA] Bug 14119 - Missing de-DE DISCHARGE message (German wording) This patch adds DISCHARGE sample message to de-DE sample_notices.pl (in GErman wording) To test: 1) prove xt/sample_notices.t, it fails 2) apply the patch 3) prove again, this time no errors Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Right wording :) Fixed version Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patches pushed to master. Good job Bernardo and Marc! |