Summary: | stage-marc-import.pl broken if plugins not enabled | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Tools | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | blocker | ||
Priority: | P5 - low | CC: | bgkriegel, dpavlin, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 12412 | ||
Bug Blocks: | |||
Attachments: |
Bug 14148: marc import broken if plugins are not enabled
[SIGNED.OFF] Bug 14148: marc import broken if plugins are not enabled [PASSED QA] Bug 14148: marc import broken if plugins are not enabled |
Description
Katrin Fischer
2015-05-05 12:44:08 UTC
Created attachment 38853 [details] [review] Bug 14148: marc import broken if plugins are not enabled Bug 12412 introduced a way to use plugins to generate MARC records out of any arbitrary format. But failed to properly check for a valid configuration (plugins_enabled entry on koha-conf.xml, and even the UseKohaPlugins syspref). This patch makes tools/stage-marc-import.pl test for the required configuration before attempting to create the Koha::Plugins object. To test: 1/ Make sure you don't have a plugins_enabled entry on your koha-conf.xml file 2/ On master, browse to tools/stage-marc-import.pl => FAIL: You get a nasty "Can't call method "GetPlugins"..." error 3/ Apply the patch and reload => SUCCESS: Stage MARC for import page renders correctly Repeat with plugins_enabled == 0 and == 1. Also UseKohaPlugins enabled/disabled. It should work as expected. Regards Tomas Created attachment 38873 [details] [review] [SIGNED.OFF] Bug 14148: marc import broken if plugins are not enabled Bug 12412 introduced a way to use plugins to generate MARC records out of any arbitrary format. But failed to properly check for a valid configuration (plugins_enabled entry on koha-conf.xml, and even the UseKohaPlugins syspref). This patch makes tools/stage-marc-import.pl test for the required configuration before attempting to create the Koha::Plugins object. To test: 1/ Make sure you don't have a plugins_enabled entry on your koha-conf.xml file 2/ On master, browse to tools/stage-marc-import.pl => FAIL: You get a nasty "Can't call method "GetPlugins"..." error 3/ Apply the patch and reload => SUCCESS: Stage MARC for import page renders correctly Repeat with plugins_enabled == 0 and == 1. Also UseKohaPlugins enabled/disabled. It should work as expected. Regards Tomas Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described, no koha-qa errors Created attachment 38887 [details] [review] [PASSED QA] Bug 14148: marc import broken if plugins are not enabled Bug 12412 introduced a way to use plugins to generate MARC records out of any arbitrary format. But failed to properly check for a valid configuration (plugins_enabled entry on koha-conf.xml, and even the UseKohaPlugins syspref). This patch makes tools/stage-marc-import.pl test for the required configuration before attempting to create the Koha::Plugins object. To test: 1/ Make sure you don't have a plugins_enabled entry on your koha-conf.xml file 2/ On master, browse to tools/stage-marc-import.pl => FAIL: You get a nasty "Can't call method "GetPlugins"..." error 3/ Apply the patch and reload => SUCCESS: Stage MARC for import page renders correctly Repeat with plugins_enabled == 0 and == 1. Also UseKohaPlugins enabled/disabled. It should work as expected. Regards Tomas Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described, no koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Patch pushed to master. |