Summary: | C4::Matcher is mangling data to match on | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | Cataloging | Assignee: | Galen Charlton <gmcharlt> |
Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | dcook, gmcharlt, m.de.rooy, sfayle, tmisilo, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 14238 - Unit Test to demonstrate issue
Bug 14238 - Unit Test to demonstrate issue |
Description
Kyle M Hall (khall)
2015-05-20 16:19:42 UTC
Created attachment 39352 [details] [review] Bug 14238 - Unit Test to demonstrate issue Hey Kyle, I've had the same issue when doing matching. Since it has no documentation, I've left it in Koha, but I've created a "none" or "raw" normalizer which skips C4::Matcher::_normalize, as it was butchering URLs... You can see the signed off patch at: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 Is this report specific to 3.18.x? If it is valid in master, please mark it as such. Created attachment 52897 [details] [review] Bug 14238 - Unit Test to demonstrate issue Oh... I should add a unit test for the URL mangling as well... Kyle, what do you need to move forward on this one? Bug 17318 introduces new normalization routines (including the misterious option 'None') which could be considered a solution to this bug, and probably also 15541. Kyle, Galen, David: would you agree on closing this one as duplicate of bug 17318? (In reply to Tomás Cohen Arazi from comment #7) > Bug 17318 introduces new normalization routines (including the misterious > option 'None') which could be considered a solution to this bug, and > probably also 15541. > > Kyle, Galen, David: would you agree on closing this one as duplicate of bug > 17318? Yep, so long as there's no normalization happening during the matching, I'm happy :). (In reply to David Cook from comment #8) > (In reply to Tomás Cohen Arazi from comment #7) > > Bug 17318 introduces new normalization routines (including the misterious > > option 'None') which could be considered a solution to this bug, and > > probably also 15541. > > > > Kyle, Galen, David: would you agree on closing this one as duplicate of bug > > 17318? > > Yep, so long as there's no normalization happening during the matching, I'm > happy :). Also agreed! *** This bug has been marked as a duplicate of bug 17318 *** |