Description
Marcel de Rooy
2015-05-29 06:23:08 UTC
I will try to address some of the points raised on bug 6874: [1] The new dependency Test/CGI/Multipart.pm is marked as not required. But you do unconditionally use it in the unit test. Should it be required? No. You are not required to run t/db_dependent tests, and that is the only place it is used. Should the test fail nicely if not installed? I'd be willing to ponder a patch for that. (In reply to M. Tompsett from comment #1) > No. You are not required to run t/db_dependent tests, and that is the only > place it is used. Should the test fail nicely if not installed? I'd be > willing to ponder a patch for that. I agree that we do not really need that. Same case for some other modules and tests. Submitted bug 14321 now (larger patch, one module instead of two; and some additional benefits) (In reply to Marcel de Rooy from comment #3) > Submitted bug 14321 now (larger patch, one module instead of two; and some > additional benefits) 14321 got pushed now; we also need bug 14893 now. (In reply to Marcel de Rooy from comment #5) > Bug 14686 should be the next point to address. I have been waiting quite a while now for bug 14893 now to move further. But it did not (yet). If you are interested in this development, please help by signing that one off ! Thanks in advance :) Three reports in NSO now: 17501 for Koha Object, 17669 for purging temp files and 17777 for a fix in koha-remove. |