Created attachment 58181 [details] [review] Bug 17777: koha-remove should deal with temporary uploads If the temporary upload folder exists, it should be discarded when removing an instance. If we do not, it may/will create problems when recreating the same instance. A function in koha-functions.sh is added to determine the temp directory instead of hardcoding /tmp. Test plan: [1] Copy koha-functions.sh to /usr/share/koha/bin [2] Run koha-create --create-db newinstancexx [3] Run mkdir /tmp/koha_newinstancexx_upload (if /tmp is your temp!) [4] Run debian/scripts/koha-remove newinstancexx Do not run the regular one, but verify that you use the updated one. [5] Check that /tmp/koha_newinstancexx_upload is gone. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 59035 [details] [review] Bug 17777: koha-remove should deal with temporary uploads If the temporary upload folder exists, it should be discarded when removing an instance. If we do not, it may/will create problems when recreating the same instance. A function in koha-functions.sh is added to determine the temp directory instead of hardcoding /tmp. Test plan: [1] Copy koha-functions.sh to /usr/share/koha/bin [2] Run koha-create --create-db newinstancexx [3] Run mkdir /tmp/koha_newinstancexx_upload (if /tmp is your temp!) [4] Run debian/scripts/koha-remove newinstancexx Do not run the regular one, but verify that you use the updated one. [5] Check that /tmp/koha_newinstancexx_upload is gone. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Karen Jen <karenliang.student@wegc.school.nz>
Created attachment 59076 [details] [review] Bug 17777: koha-remove should deal with temporary uploads If the temporary upload folder exists, it should be discarded when removing an instance. If we do not, it may/will create problems when recreating the same instance. A function in koha-functions.sh is added to determine the temp directory instead of hardcoding /tmp. Test plan: [1] Copy koha-functions.sh to /usr/share/koha/bin [2] Run koha-create --create-db newinstancexx [3] Run mkdir /tmp/koha_newinstancexx_upload (if /tmp is your temp!) [4] Run debian/scripts/koha-remove newinstancexx Do not run the regular one, but verify that you use the updated one. [5] Check that /tmp/koha_newinstancexx_upload is gone. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Karen Jen <karenliang.student@wegc.school.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Thanks Karen and Jonathan
Karen: do not change the assignee please. Thanks.
Pushed to master for 17.05, thanks Marcel!
(In reply to Marcel de Rooy from comment #5) > Karen: do not change the assignee please. Thanks. Ahh I told them too, because they weren't getting any mail otherwise. I wanted them to get the emails telling them they were pushed, there is a bug somewhere in bugzilla at the moment when you attach a patch you dont get added to the cc. (Of course the patch author is what really matters I guess)
This patch has been pushed to 16.11.x and will be in 16.11.02.
Pushed to 16.05.x, for 16.05.08 release