| Summary: | Test calls C4::Context::set_userenv | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mark Tompsett <mtompset> |
| Component: | Architecture, internals, and plumbing | Assignee: | Mark Tompsett <mtompset> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | chris, indradg, m.de.rooy, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 |
||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 14325: Test calls C4::Context::set_userenv
Bug 14325: Test calls C4::Context::set_userenv Bug 14325: Test calls C4::Context::set_userenv |
||
|
Description
Mark Tompsett
2015-06-03 19:16:24 UTC
Created attachment 39826 [details] [review] Bug 14325: Test calls C4::Context::set_userenv This is a case of works by accident. This patch corrects the set_userenv call. TEST PLAN --------- 1) prove t/db_dependent/Borrower_Discharge.t -- works 2) git grep :set_userenv -- only this one file. 3) Confirm the the C4/Context.pm has a set_userenv which shifts the first parameter, as intended for a -> call and not a :: call. 4) apply patch 5) prove t/db_dependent/Borrower_Discharge.t -- still works 6) git grep :set_userenv -- nothing now. 7) run koha qa test tools Created attachment 39828 [details] [review] Bug 14325: Test calls C4::Context::set_userenv This is a case of works by accident. This patch corrects the set_userenv call. TEST PLAN --------- 1) prove t/db_dependent/Borrower_Discharge.t -- works 2) git grep :set_userenv -- only this one file. 3) Confirm the the C4/Context.pm has a set_userenv which shifts the first parameter, as intended for a -> call and not a :: call. 4) apply patch 5) prove t/db_dependent/Borrower_Discharge.t -- still works 6) git grep :set_userenv -- nothing now. 7) run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Created attachment 39833 [details] [review] Bug 14325: Test calls C4::Context::set_userenv This is a case of works by accident. This patch corrects the set_userenv call. TEST PLAN --------- 1) prove t/db_dependent/Borrower_Discharge.t -- works 2) git grep :set_userenv -- only this one file. 3) Confirm the the C4/Context.pm has a set_userenv which shifts the first parameter, as intended for a -> call and not a :: call. 4) apply patch 5) prove t/db_dependent/Borrower_Discharge.t -- still works 6) git grep :set_userenv -- nothing now. 7) run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Patch pushed to master. Thanks Mark! Pushed to 3.20.x will be in 3.20.1 |