Summary: | Improvements to the 'Transfers to receive' page (branchname, mailto link) | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | chris, liz, mtj, nick, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 14356: Improvements to the 'Transfers to receive' page
Bug 14356: Improvements to the 'Transfers to receive' page Bug 14356: Improvements to the 'Transfers to receive' page |
Description
Katrin Fischer
2015-06-06 23:43:20 UTC
Created attachment 39963 [details] [review] Bug 14356: Improvements to the 'Transfers to receive' page Patch makes several small changes to the template for the 'Transfers to receive page' 1) Show the branch name instead of the branchcode in the table of incoming transfers. If there is a hold connected with the transfer: 2) Show the patron's name as 'surname, firstname' intead of 'surname firstname' 3) Restore broken feature: Show a mailto: link with a generated subject of 'Hold: <title>'. The mailto: feature actually existed in the templates, but was broken to a misnamed database column. I made some small changes to make the subject translatable (see bug 8330). To test: - Create a transfer by placing a hold with pickup at another library - Craete a transfer manually - Go to the circulation > transfers to receive - Check the changes explained above, compare before and after - Check the mailto: link works as expected Bonus: Check the Hold: bit in the subject is really translatable now. Created attachment 40084 [details] [review] Bug 14356: Improvements to the 'Transfers to receive' page Patch makes several small changes to the template for the 'Transfers to receive page' 1) Show the branch name instead of the branchcode in the table of incoming transfers. If there is a hold connected with the transfer: 2) Show the patron's name as 'surname, firstname' intead of 'surname firstname' 3) Restore broken feature: Show a mailto: link with a generated subject of 'Hold: <title>'. The mailto: feature actually existed in the templates, but was broken to a misnamed database column. I made some small changes to make the subject translatable (see bug 8330). To test: - Create a transfer by placing a hold with pickup at another library - Craete a transfer manually - Go to the circulation > transfers to receive - Check the changes explained above, compare before and after - Check the mailto: link works as expected Bonus: Check the Hold: bit in the subject is really translatable now. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Bonus was tested too and succeeded :-) Created attachment 40189 [details] [review] Bug 14356: Improvements to the 'Transfers to receive' page Patch makes several small changes to the template for the 'Transfers to receive page' 1) Show the branch name instead of the branchcode in the table of incoming transfers. If there is a hold connected with the transfer: 2) Show the patron's name as 'surname, firstname' intead of 'surname firstname' 3) Restore broken feature: Show a mailto: link with a generated subject of 'Hold: <title>'. The mailto: feature actually existed in the templates, but was broken to a misnamed database column. I made some small changes to make the subject translatable (see bug 8330). To test: - Create a transfer by placing a hold with pickup at another library - Craete a transfer manually - Go to the circulation > transfers to receive - Check the changes explained above, compare before and after - Check the mailto: link works as expected Bonus: Check the Hold: bit in the subject is really translatable now. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Patch pushed to master. Thanks Katrina! Pushed to 3.20.x will be in 3.20.2 Pushed to 3.18.x will be in 3.18.09 Pushed to 3.16.x, will be in 3.16.13 |