Description
Kyle M Hall (khall)
2015-07-06 13:43:29 UTC
Created attachment 40806 [details] [review] Bug 14497 - Add warning to patron details page if patron's fines exceed noissuescharge Some librarians have requested that the same warning on the check out page be placed on the patron details page if a patron's fines exceed the system preference noissuescharge. Test Plan: 1) Apply this patch 2) Find or create a patron who's fines exceed noissuescharge 3) Browse to that patron's details ( moremember.pl ) 4) You should see a warning near the top of the page with links to the patron's account page and the pay fines page Created attachment 45127 [details] [review] Bug 14497 - Add warning to patron details page if patron's fines exceed noissuescharge Some librarians have requested that the same warning on the check out page be placed on the patron details page if a patron's fines exceed the system preference noissuescharge. Test Plan: 1) Apply this patch 2) Find or create a patron who's fines exceed noissuescharge 3) Browse to that patron's details ( moremember.pl ) 4) You should see a warning near the top of the page with links to the patron's account page and the pay fines page Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Internal sign off only This sentence will be almost intranslatable because it is splitted by html tags: Checkouts are BLOCKED because fine balance is OVER THE LIMIT. We have something similar with Bug 15274. Based on Marc's Comment 4 I think this should be "Failed QA" for now. Created attachment 50396 [details] [review] Bug 14497 [QA Followup] - Make message more easily translated I get different messages on checkout and detail if 'AllowFineOverride' is set to 'Allow.' The detail page says checkouts are blocked, but the checkout page doesn't. The checkout page is correct in this case because the user can override the block. Note that circulation.tt checks "[% IF ( charges_is_blocker ) %]" at line 789. Created attachment 50431 [details] [review] Bug 14497 - Add warning to patron details page if patron's fines exceed noissuescharge Some librarians have requested that the same warning on the check out page be placed on the patron details page if a patron's fines exceed the system preference noissuescharge. Test Plan: 1) Apply this patch 2) Find or create a patron who's fines exceed noissuescharge 3) Browse to that patron's details ( moremember.pl ) 4) You should see a warning near the top of the page with links to the patron's account page and the pay fines page Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Patch ammended post sign-off (In reply to Owen Leonard from comment #7) > I get different messages on checkout and detail if 'AllowFineOverride' is > set to 'Allow.' The detail page says checkouts are blocked, but the checkout > page doesn't. The checkout page is correct in this case because the user can > override the block. > > Note that circulation.tt checks "[% IF ( charges_is_blocker ) %]" at line > 789. Right you are! I've made those additions and squashed all the patches together for readability. Patch tested with a sandbox, by Sally Healey <sally.healey@cheshiresharedservices.gov.uk> Created attachment 50461 [details] [review] Bug 14497 - Add warning to patron details page if patron's fines exceed noissuescharge Some librarians have requested that the same warning on the check out page be placed on the patron details page if a patron's fines exceed the system preference noissuescharge. Test Plan: 1) Apply this patch 2) Find or create a patron who's fines exceed noissuescharge 3) Browse to that patron's details ( moremember.pl ) 4) You should see a warning near the top of the page with links to the patron's account page and the pay fines page Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Patch ammended post sign-off Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk> Kyle, don't you think it is worth to refactore this code (move it to an include file or something)? Created attachment 50718 [details] [review] Bug 14497 [QA Followup] - Refactor code to have a single source for message Created attachment 50748 [details] [review] Bug 14497 - Add warning to patron details page if patron's fines exceed noissuescharge Some librarians have requested that the same warning on the check out page be placed on the patron details page if a patron's fines exceed the system preference noissuescharge. Test Plan: 1) Apply this patch 2) Find or create a patron who's fines exceed noissuescharge 3) Browse to that patron's details ( moremember.pl ) 4) You should see a warning near the top of the page with links to the patron's account page and the pay fines page Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Patch ammended post sign-off Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 50749 [details] [review] Bug 14497 [QA Followup] - Refactor code to have a single source for message Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> The patch does what it describes, but it would be nice to have the alert better displayed (a dedicated div for instance, it would be even easier to hide it if someone does not want it). Pushed to master for the May 2016 release! |