Summary: | Send courtesy notices when sys pref EnhancedMessagingPreferences is OFF | ||
---|---|---|---|
Product: | Koha | Reporter: | Zeno Tajoli <ztajoli> |
Component: | Command-line Utilities | Assignee: | Zeno Tajoli <ztajoli> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | robin, tomascohen, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 |
||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: | new script |
Description
Zeno Tajoli
2015-07-12 10:58:22 UTC
Created attachment 40950 [details] [review] new script Hi Zeno, I am not sure about the idea of this patch. It seems to duplicate a lot of the existing script with the only difference being additional command line parameters? I wonder if we shouldn't include this in the existing script? Hi Katrin, in fact the script is a simplified version of advance_notices.pl, with those differences: -- It works when EnhancedMessagingPreferences is OFF (reverse of advance_notices.pl) -- You can limit by library -- You can select the print template -- You can't select digest/no digest, only digest In copyright notice I mantain "Liblime 2008" because I reuse much code. (In reply to Zeno Tajoli from comment #3) > Hi Katrin, > > in fact the script is a simplified version of advance_notices.pl, with those > differences: > -- It works when EnhancedMessagingPreferences is OFF (reverse of > advance_notices.pl) > -- You can limit by library > -- You can select the print template > -- You can't select digest/no digest, only digest > > In copyright notice I mantain "Liblime 2008" because I reuse much code. Zeno, I agree with Katrina here. This is just another notice to be sent. I would rather add the option switch and think of this as just another configurable notice to be sent. Hi Katrin and Tomás, ok I try to do the same probably with a modification of overdue_notices.pl. The problem is that advance_notices.pl is written with EnhancedMessagingPreferences = ON in mind and it is quite difficult to insert a good behaviour where EnhancedMessagingPreferences = OFF. Bye Hi Zeno, one of my problems here I think is understanding why you need to keep the pref off - why is the library not using the default behaviour? Hi Katrin, the motivation of EnhancedMessagingPreferences = OFF is the library doesen't want that users could personalize messaging. Hm, maybe the solution then would be Bug 9254 - New option to block patrons from changing messaging preferences in OPAC? Another problem if you turn off the pref is, that the notice tab doesn't display in the staff patron account (bug 14157) (In reply to Katrin Fischer from comment #8) > Hm, maybe the solution then would be Bug 9254 - New option to block patrons > from changing messaging preferences in OPAC? Yes 9354 could be a good answer for my requests. (In reply to Zeno Tajoli from comment #9) > (In reply to Katrin Fischer from comment #8) > > Hm, maybe the solution then would be Bug 9254 - New option to block patrons > > from changing messaging preferences in OPAC? > > Yes 9354 could be a good answer for my requests. Hi Zeno, Bug 9254 is marked as duplicate of: Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC (Pushed to master) Does 12528 resolve your request? Hi, in fact yes 12528 resolve my request. I close the bug. Bye |