Bug 14519 - Send courtesy notices when sys pref EnhancedMessagingPreferences is OFF
Summary: Send courtesy notices when sys pref EnhancedMessagingPreferences is OFF
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Zeno Tajoli
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-12 10:58 UTC by Zeno Tajoli
Modified: 2017-06-14 22:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
new script (13.33 KB, patch)
2015-07-12 11:07 UTC, Zeno Tajoli
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Zeno Tajoli 2015-07-12 10:58:22 UTC
This new script in misc/cronjobs/ it is written to send
courtesy notices when sys pref EnhancedMessagingPreferences is OFF.

You can limit by library, setup how many day the message is sent, select the digest template to use for message.
Comment 1 Zeno Tajoli 2015-07-12 11:07:54 UTC
Created attachment 40950 [details] [review]
new script
Comment 2 Katrin Fischer 2015-07-12 22:29:41 UTC
Hi Zeno, 

I am not sure about the idea of this patch. It seems to duplicate a lot of the existing script with the only difference being additional command line parameters?

I wonder if we shouldn't include this in the existing script?
Comment 3 Zeno Tajoli 2015-07-13 06:51:28 UTC
Hi Katrin,

in fact the script is a simplified version of advance_notices.pl, with those
differences:
-- It works when EnhancedMessagingPreferences is OFF (reverse of advance_notices.pl)
-- You can limit by library
-- You can select the print template
-- You can't select digest/no digest, only digest

In copyright notice I mantain "Liblime 2008" because I reuse much code.
Comment 4 Tomás Cohen Arazi 2015-07-28 23:02:33 UTC
(In reply to Zeno Tajoli from comment #3)
> Hi Katrin,
> 
> in fact the script is a simplified version of advance_notices.pl, with those
> differences:
> -- It works when EnhancedMessagingPreferences is OFF (reverse of
> advance_notices.pl)
> -- You can limit by library
> -- You can select the print template
> -- You can't select digest/no digest, only digest
> 
> In copyright notice I mantain "Liblime 2008" because I reuse much code.

Zeno, I agree with Katrina here. This is just another notice to be sent. I would rather add the option switch and think of this as just another configurable notice to be sent.
Comment 5 Zeno Tajoli 2015-07-29 09:40:52 UTC
Hi Katrin and Tomás, 

ok I try to do the same probably with a modification of overdue_notices.pl.

The problem is that advance_notices.pl is written with EnhancedMessagingPreferences = ON in mind and it is quite difficult to insert
a good behaviour where EnhancedMessagingPreferences = OFF.

Bye
Comment 6 Katrin Fischer 2015-07-29 10:13:02 UTC
Hi Zeno,

one of my problems here I think is understanding why you need to keep the pref off - why is the library not using the default behaviour?
Comment 7 Zeno Tajoli 2015-07-29 10:20:31 UTC
Hi Katrin,

the motivation of EnhancedMessagingPreferences = OFF is the library doesen't want that users could personalize messaging.
Comment 8 Katrin Fischer 2015-07-29 10:48:51 UTC
Hm, maybe the solution then would be Bug 9254 - New option to block patrons from changing messaging preferences in OPAC?

Another problem if you turn off the pref is, that the notice tab doesn't display in the staff patron account (bug 14157)
Comment 9 Zeno Tajoli 2015-07-29 12:03:56 UTC
(In reply to Katrin Fischer from comment #8)
> Hm, maybe the solution then would be Bug 9254 - New option to block patrons
> from changing messaging preferences in OPAC?

Yes 9354 could be a good answer for my requests.
Comment 10 Marc Véron 2016-10-02 15:35:50 UTC
(In reply to Zeno Tajoli from comment #9)
> (In reply to Katrin Fischer from comment #8)
> > Hm, maybe the solution then would be Bug 9254 - New option to block patrons
> > from changing messaging preferences in OPAC?
> 
> Yes 9354 could be a good answer for my requests.

Hi Zeno,

Bug 9254 is marked as duplicate of:
Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC (Pushed to master)

Does 12528 resolve your request?
Comment 11 Zeno Tajoli 2016-10-02 15:40:49 UTC
Hi, 
in fact yes 12528 resolve my request.
I close the bug.

Bye