Summary: | Warns when sending a list via email on OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | OPAC | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | f.demians, katrin.fischer |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: | Bug 14551: Silencing warn triggered by sending a list via email on OPAC |
Description
Aleisha Amohia
2015-07-17 03:22:17 UTC
Created attachment 41049 [details] [review] Bug 14551: Silencing warn triggered by sending a list via email on OPAC Uninitialized value $sort_direction To test: 1) To recreate, select any list from the Lists menu on the OPAC 2) Click 'Send list' 3) Enter an email address to send the list to and click 'Send' 4) Notice warn in error log 5) Apply patch, refresh page and resend list 6) Notice warn is gone but page still works Comment on attachment 41049 [details] [review] Bug 14551: Silencing warn triggered by sending a list via email on OPAC Review of attachment 41049 [details] [review]: ----------------------------------------------------------------- ::: C4/VirtualShelves.pm @@ +264,4 @@ > $sth2->execute($shelfnumber); > ($sortfield) = $sth2->fetchrow_array; > } > + $sort_direction //= ''; Am I missing something? I don't see a difference, except for white space and vertical spacing. I don't see any warning. The patch itself does nothing to my eyes. I don't see any option to Send List anymore so will set to Resolved Hi Aleisha, have you been logged in when looking at the list? The feature still exists. (In reply to Katrin Fischer from comment #5) > Hi Aleisha, have you been logged in when looking at the list? The feature > still exists. Oops you're right I did something weird there, feature still exists but warns are gone so will change to Fixed! |