Bug 14551 - Warns when sending a list via email on OPAC
Summary: Warns when sending a list via email on OPAC
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-17 03:22 UTC by Aleisha Amohia
Modified: 2016-12-05 21:23 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 14551: Silencing warn triggered by sending a list via email on OPAC (1.23 KB, patch)
2015-07-17 03:37 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2015-07-17 03:22:17 UTC
opac-sendshelf.pl: Use of uninitialized value $sort_direction in string eq at /home/vagrant/kohaclone/C4/VirtualShelves.pm line 280

To recreate, select any list from the Lists menu on the OPAC
click 'Send list'
Enter an email address to send the list to and click 'Send'
Notice warn
Comment 1 Aleisha Amohia 2015-07-17 03:37:52 UTC
Created attachment 41049 [details] [review]
Bug 14551: Silencing warn triggered by sending a list via email on OPAC

Uninitialized value $sort_direction

To test:

1) To recreate, select any list from the Lists menu on the OPAC
2) Click 'Send list'
3) Enter an email address to send the list to and click 'Send'
4) Notice warn in error log
5) Apply patch, refresh page and resend list
6) Notice warn is gone but page still works
Comment 2 Mark Tompsett 2015-07-17 04:06:06 UTC
Comment on attachment 41049 [details] [review]
Bug 14551: Silencing warn triggered by sending a list via email on OPAC

Review of attachment 41049 [details] [review]:
-----------------------------------------------------------------

::: C4/VirtualShelves.pm
@@ +264,4 @@
>          $sth2->execute($shelfnumber);
>          ($sortfield) = $sth2->fetchrow_array;
>      }
> +    $sort_direction //= ''; 

Am I missing something? I don't see a difference, except for white space and vertical spacing.
Comment 3 Frédéric Demians 2015-11-11 13:07:03 UTC
I don't see any warning. The patch itself does nothing to my eyes.
Comment 4 Aleisha Amohia 2015-12-13 22:30:59 UTC
I don't see any option to Send List anymore so will set to Resolved
Comment 5 Katrin Fischer 2015-12-13 22:31:45 UTC
Hi Aleisha, have you been logged in when looking at the list? The feature still exists.
Comment 6 Aleisha Amohia 2015-12-13 23:07:25 UTC
(In reply to Katrin Fischer from comment #5)
> Hi Aleisha, have you been logged in when looking at the list? The feature
> still exists.

Oops you're right I did something weird there, feature still exists but warns are gone so will change to Fixed!